Fix race condition in config file parsing#291
Open
jessefaler wants to merge 1 commit intopterodactyl:developfrom
Open
Fix race condition in config file parsing#291jessefaler wants to merge 1 commit intopterodactyl:developfrom
jessefaler wants to merge 1 commit intopterodactyl:developfrom
Conversation
jessefaler
force-pushed
the
fix/parser-race
branch
from
6aad97b to
23be512
Compare
Add file locking and syncing to prevent server processes from reading
config files while they're being updated. Also document that
json.Marshal(config.Get()) is used to resolve {{config.*}} placeholders.
jessefaler
force-pushed
the
fix/parser-race
branch
from
23be512 to
f275399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add file locking and syncing to prevent server processes from reading config files while they're being updated. Also document that json.Marshal(config.Get()) is used to resolve {{config.*}} placeholders.