adding dataplots.jl

[erandichavez]

Comrade plotting functionality for observation data. Currently supports Makie figures and Makie subplots.

[ptiede]

This looks fantastic and I am really excited to get these in Comrade. The biggest thing that needs to change before merging is moving this to an extension. Other than that the rest of the comments are minor.

There is a potential generalization I mention but maybe we can work on that after this is merged.

[ptiede]

Extension details here
https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

[erandichavez]

The plotting code has now been moved to an extension with all your suggestions implemented! (if I blew up your email with these commits i am so sorry)

[ptiede]

Amazing!

One quick thing is to move from CairoMakie to just Makie in the extension/weakdep. If we do that, the extension will load for any Makie backend including GLMakie and CairoMakie.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (fa08071) to head (d063634).
Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files          29       29           
  Lines        1658     1659    +1     
=======================================
+ Hits         1539     1540    +1     
  Misses        119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ptiede]

The doc failures are just because we need to add the new doc strings to the docs.

[erandichavez]

I've added docstrings and changed the dependency from CairoMakie to just Makie so i think it should be good to merge now!

[ptiede]

I don't see the docstrings in docs/src/api.md. Could you add them under a new section ### Plotting

[ptiede]

This should do the trick in api.md

## Plotting

!!! warning
    A user must first load a `Makie` backend, e.g., `CairoMakie` to use this functionality

```@docs
Comrade.plotfields
Comrade.axisfields
Comrade.plotcaltable
```

I'm really excited to get this in because I want to use it for some of my 2021 stuff :p

[erandichavez]

Done! Docs added to api.md now lets gooooo!!