Skip to content

Set default visdomain executor to be the same as grid.#432

Merged
ptiede merged 1 commit intoptiede:mainfrom
jumerckx:jm/visdomain_executor
Dec 10, 2025
Merged

Set default visdomain executor to be the same as grid.#432
ptiede merged 1 commit intoptiede:mainfrom
jumerckx:jm/visdomain_executor

Conversation

@jumerckx
Copy link
Contributor

@jumerckx jumerckx commented Dec 8, 2025

Unsure if this is something that makes sense.

@ptiede
Copy link
Owner

ptiede commented Dec 8, 2025

This makes a ton of sense.

@ptiede
Copy link
Owner

ptiede commented Dec 8, 2025

I'll also work on making this more generic in a separate PR. I can just add a keyword argument.

@jumerckx jumerckx marked this pull request as ready for review December 8, 2025 23:00
@ptiede
Copy link
Owner

ptiede commented Dec 9, 2025

These failures are due to bizarre behavior introduced in the newest TransformVariables. It also seems to be causing a segmentation fault in Julia's type inference...

This segfault it actually coming from Enzyme. I'm trying to fix this in #433

@ptiede ptiede merged commit 4f85f1b into ptiede:main Dec 10, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants