Skip to content

Add ability to specify image domain measurements#438

Merged
ptiede merged 21 commits intomainfrom
ptiede-imagemeas
Jan 5, 2026
Merged

Add ability to specify image domain measurements#438
ptiede merged 21 commits intomainfrom
ptiede-imagemeas

Conversation

@ptiede
Copy link
Owner

@ptiede ptiede commented Dec 23, 2025

Eventually, it would be nice to fold in image-domain measurements that aren't actually constrained in VLBI, e.g., absolute flux, absolute positions, SED measurements, etc.

This adds experimental support for such features. Instead of producing only visibilities for each model, we also generate the total on-sky image. Some image domain models are so we only compute the image when necessary.

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 92.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.46%. Comparing base (946c5b1) to head (4b6374e).
⚠️ Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
src/observations/dataproducts.jl 66.66% 2 Missing ⚠️
src/skymodels/fixed.jl 50.00% 2 Missing ⚠️
src/skymodels/multi.jl 77.77% 2 Missing ⚠️
src/skymodels/abstract.jl 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   92.43%   88.46%   -3.97%     
==========================================
  Files          33       40       +7     
  Lines        1823     2515     +692     
==========================================
+ Hits         1685     2225     +540     
- Misses        138      290     +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptiede
Copy link
Owner Author

ptiede commented Jan 5, 2026

Test failures are due to an Enzyme issue see EnzymeAD/Enzyme.jl#2873

@ptiede
Copy link
Owner Author

ptiede commented Jan 5, 2026

To fix the Enzyme issue I placed an upper bound. I'll relax that in the future when things work again.

@ptiede ptiede merged commit 5bdb2f5 into main Jan 5, 2026
5 of 8 checks passed
@ptiede ptiede deleted the ptiede-imagemeas branch January 5, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant