Add ability to specify image domain measurements#438
Merged
Conversation
… into ptiede-imagemeas
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
- Coverage 92.43% 88.46% -3.97%
==========================================
Files 33 40 +7
Lines 1823 2515 +692
==========================================
+ Hits 1685 2225 +540
- Misses 138 290 +152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
Test failures are due to an Enzyme issue see EnzymeAD/Enzyme.jl#2873 |
Owner
Author
|
To fix the Enzyme issue I placed an upper bound. I'll relax that in the future when things work again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventually, it would be nice to fold in image-domain measurements that aren't actually constrained in VLBI, e.g., absolute flux, absolute positions, SED measurements, etc.
This adds experimental support for such features. Instead of producing only visibilities for each model, we also generate the total on-sky image. Some image domain models are so we only compute the image when necessary.