Skip to content

Start transfer of base features to ComradeBase#54

Open
ptiede wants to merge 5 commits intomainfrom
ptiede-refactor
Open

Start transfer of base features to ComradeBase#54
ptiede wants to merge 5 commits intomainfrom
ptiede-refactor

Conversation

@ptiede
Copy link
Owner

@ptiede ptiede commented Jun 5, 2025

No description provided.

Copy link
Owner Author

@ptiede ptiede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of features from VLBISkyModels that I'd like to move to the base package so people do not necessarily need to depend on VLBISkyModels that is slightly beefy.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.69620% with 105 lines in your changes missing coverage. Please review.

Project coverage is 70.64%. Comparing base (538fd10) to head (e0dfb09).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/modifiers.jl 65.00% 63 Missing ⚠️
src/fourierdual.jl 0.00% 30 Missing ⚠️
src/multidomain.jl 65.21% 8 Missing ⚠️
src/domain.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   75.11%   70.64%   -4.48%     
==========================================
  Files          18       20       +2     
  Lines         635      872     +237     
==========================================
+ Hits          477      616     +139     
- Misses        158      256      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants