x87: Manually raise FE_OVERFLOW/FE_UNDERFLOW flags in LD2D conversion#3472
Merged
ptitSeb merged 1 commit intoptitSeb:mainfrom Feb 6, 2026
Merged
x87: Manually raise FE_OVERFLOW/FE_UNDERFLOW flags in LD2D conversion#3472ptitSeb merged 1 commit intoptitSeb:mainfrom
ptitSeb merged 1 commit intoptitSeb:mainfrom
Conversation
Signed-off-by: Zewei Yang <yangzewei@loongson.cn>
Owner
|
It's a bit strange to update global status flags but not x87 status register but ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description (Motivation): The Python NumPy software is throwing an error: A library relying on the
fenvflag to detect precision loss failed in testing (test_identity_long_short).The current
LD2D(long double to double) conversion logic is implemented through integer bitwise operations. Because it doesn't involve host FPU hardware instructions, the CPU hardware doesn't automatically set the floating-point status register flags when a value overflows or underflows occurs.Result: The NumPy exception detection issue has been fixed.