Rename leftover viteElectronBuild* task keys to esbuildElectronBuild*#681
Merged
Conversation
These custom task keys in the electron-builder example were leftovers from the Vite-based origin. Renamed to match the esbuild plugin naming. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
electron-builderexample defined two custom sbt task keys namedviteElectronBuildPackage/viteElectronBuildDistributable-- leftovers from the Vite-based origin. Since this is the esbuild plugin, they have been renamed toesbuildElectronBuildPackage/esbuildElectronBuildDistributable, along with the references in the corresponding sbt-test script.The Vite mentions in
README.mdwere left untouched, as they are intentional comparisons to scalajs-vite that explain the project design rationale.