chore: minor improvements and correction - #402
Merged
Merged
Conversation
This removes calls to `board.clone()` in razoring and nmp and instead use make/unmake like usual since the `Board` can also support unmaking null moves. bench: 1064381
Check hard timeout every 2048 nodes since there's an overhead with checking time. bench: 1064381
Don't recompute check and pinned piece metadata more than once if we don't have to. This changes how this info is passed to the move picker and where it's first computed during search. bench: 1064381
In some cases, we don't need to check see again. If a capture is yielded after the TT stage we don't check see again since it would be redundant. bench: 1064381
bench: 1064381
This will validate the pre-condition for skipping the extra see check in debug mode. bench: 1064381
bench: 1064381
Don't put aborted search results in tables or store moves as "best" if the search for that iteration was aborted or stopped early otherwise. bench: 1064381
Owner
Author
|
STC regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully improves performance in some cases with the following changes:
board.clone()calls in for NMP and razoringOne "correctness" fix, which may have been a bug previously, is that we don't let aborted search results get stored in the TT or other tables and don't propagate the result.
bench: 1064381