Add L-BFGS reconstruction engine#485
Conversation
|
@daurer this L-BFGS pull request is now ready for review and potential merge. |
|
Needs a CuPy engine before it can be merged. @ptim0626 maybe something for you? |
1686ea0 to
fecdb53
Compare
|
A quick comment, the tolerance for LBFGS's tests is increased as it is very likely the discrepancy is a result of numerical instability instead of the problem of implementation. |
|
@daurer this PR will soon need to be updated to use the wavefield preconditioner, I'm happy to do this. |
|
@daurer I've now added the wavefield preconditioner to LBFGS with tests and templates. Unfortunately pytest has stopped picking up the LBFGS tests in the CI, I assume this is the same issue that we had with the ML engine tests not being picked up? |
just saw this comment now. I think the tests should be name |
Done. All tests now running (aside from the serial wavefield caveat as in #607) and passing. |
Resurrecting #400 as GitHub broke the original PR.
Add Limited-memory BFGS reconstruction engine to as an alternative to ML.
Caveats: