Skip to content

Comments

feat: Lightning Payment Verification#3

Merged
SeverinAlexB merged 26 commits intomasterfrom
ln_payment
Dec 22, 2025
Merged

feat: Lightning Payment Verification#3
SeverinAlexB merged 26 commits intomasterfrom
ln_payment

Conversation

@SeverinAlexB
Copy link
Collaborator

@SeverinAlexB SeverinAlexB commented Dec 16, 2025

Adds Lightning Payment Verifications to Homegate. It provides 3 endpoints:

  • Create verification -> Provides a Bolt11 invoice
  • Get verification -> Provides the state of the verification.
  • Await verification -> Long poll endpoint that completes when the payment arrives.

I am not sure how/if I can test anything that involves phoenixd. It would require a lot of mocking which I am not sure is worth it. At the moment, the flow is mostly tested manually.

@SeverinAlexB SeverinAlexB marked this pull request as ready for review December 18, 2025 11:03
@SeverinAlexB SeverinAlexB requested a review from 86667 December 18, 2025 11:03
Copy link
Contributor

@86667 86667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the syncer logic to go over still, here's the first few suggestions

Copy link
Contributor

@86667 86667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syncer looks good 👍

@SeverinAlexB SeverinAlexB requested a review from 86667 December 19, 2025 08:20
@86667
Copy link
Contributor

86667 commented Dec 22, 2025

Couple points about API responses:

  • We return id but document input param as payment_hash
  • We have a mix of camel case and snake case- Ln response types are converted to camel case at serialisation.

@SeverinAlexB SeverinAlexB merged commit c6cf3ee into master Dec 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants