Conversation
86667
approved these changes
Dec 18, 2025
Contributor
86667
left a comment
86667
left a comment
There was a problem hiding this comment.
This is fine, it would probably actually be cheaper though to do the homeserver check before creating a verification session, ie in /sms_verification/send_code and /ln_verification. This would also catch failed homeservers more consistently as there wouldnt be up to a 10s gap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a background task to homegate that continuously calls the homeserver and crashes homegate in case the homeserver is unreachable. This is to prevent handing out LN/SMS verifications without being able to generate a signup token.