Adjust CSS styling of rich text toolbar to Bootstrap 4 for consistency #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #664 Adjust the CSS styling of the rich text toolbar buttons to match Bootstrap 4 for consistency. * Add the `btn` and `btn-light` classes to the buttons in `src/adapters/PublicLab.Woofmark.js`. * Remove the `btn-sm` class from the buttons in `src/adapters/PublicLab.Woofmark.js`. * Remove the `btn-outline-secondary` class from the `woofmark-command-insert` button in `src/modules/PublicLab.CustomInsert.js`. * Add the `btn` and `btn-light` classes to the `woofmark-command-insert` button in `src/modules/PublicLab.CustomInsert.js`. * Remove the `btn-outline-secondary` class from the `woofmark-command-autocenter` button in `src/modules/PublicLab.RichTextModule.AutoCenter.js`. * Add the `btn` and `btn-light` classes to the `woofmark-command-autocenter` button in `src/modules/PublicLab.RichTextModule.AutoCenter.js`. * Remove the `btn-outline-secondary` class from the `woofmark-command-embed` button in `src/modules/PublicLab.RichTextModule.Embed.js`. * Add the `btn` and `btn-light` classes to the `woofmark-command-embed` button in `src/modules/PublicLab.RichTextModule.Embed.js`. * Remove the `btn-outline-secondary` class from the `woofmark-command-horizontal-rule` button in `src/modules/PublicLab.RichTextModule.HorizontalRule.js`. * Add the `btn` and `btn-light` classes to the `woofmark-command-horizontal-rule` button in `src/modules/PublicLab.RichTextModule.HorizontalRule.js`. * Remove the `btn-outline-secondary` class from the `woofmark-command-table` button in `src/modules/PublicLab.RichTextModule.Table.js`. * Add the `btn` and `btn-light` classes to the `woofmark-command-table` button in `src/modules/PublicLab.RichTextModule.Table.js`.
Fix basic bugs in the UI. * Enable the "Publish" button in `examples/index.html` when all required fields are filled by adding an event listener. * Remove the "Drag an image here to upload" text in `examples/errors.html` after an image is uploaded. * Fix the toolbar in `src/modules/PublicLab.RichTextModule.js` to float correctly when scrolling through the editor text area. * Remove the markdown warning message in `src/modules/PublicLab.RichTextModule.js` after switching to markdown mode. * Remove the data URLs warning message in `src/modules/PublicLab.RichTextModule.js` after removing the invalid image format. * Remove the invalid bold tags warning message in `src/modules/PublicLab.RichTextModule.js` after removing the invalid tags.
Fix UI bugs in PublicLab.Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #664
Adjust the CSS styling of the rich text toolbar buttons to match Bootstrap 4 for consistency.
btnandbtn-lightclasses to the buttons insrc/adapters/PublicLab.Woofmark.js.btn-smclass from the buttons insrc/adapters/PublicLab.Woofmark.js.btn-outline-secondaryclass from thewoofmark-command-insertbutton insrc/modules/PublicLab.CustomInsert.js.btnandbtn-lightclasses to thewoofmark-command-insertbutton insrc/modules/PublicLab.CustomInsert.js.btn-outline-secondaryclass from thewoofmark-command-autocenterbutton insrc/modules/PublicLab.RichTextModule.AutoCenter.js.btnandbtn-lightclasses to thewoofmark-command-autocenterbutton insrc/modules/PublicLab.RichTextModule.AutoCenter.js.btn-outline-secondaryclass from thewoofmark-command-embedbutton insrc/modules/PublicLab.RichTextModule.Embed.js.btnandbtn-lightclasses to thewoofmark-command-embedbutton insrc/modules/PublicLab.RichTextModule.Embed.js.btn-outline-secondaryclass from thewoofmark-command-horizontal-rulebutton insrc/modules/PublicLab.RichTextModule.HorizontalRule.js.btnandbtn-lightclasses to thewoofmark-command-horizontal-rulebutton insrc/modules/PublicLab.RichTextModule.HorizontalRule.js.btn-outline-secondaryclass from thewoofmark-command-tablebutton insrc/modules/PublicLab.RichTextModule.Table.js.btnandbtn-lightclasses to thewoofmark-command-tablebutton insrc/modules/PublicLab.RichTextModule.Table.js.