Skip to content

done with the update - #210

Open
ananya218 wants to merge 2 commits into
publiclab:mainfrom
ananya218:main
Open

done with the update#210
ananya218 wants to merge 2 commits into
publiclab:mainfrom
ananya218:main

Conversation

@ananya218

Copy link
Copy Markdown

No description provided.

@welcome

welcome Bot commented Oct 18, 2019

Copy link
Copy Markdown

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@VladimirMikulic VladimirMikulic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ananya218 could you please rebase this branch and explain to me what issue you were fixing?
Thanks.

@tristan-f-r

Copy link
Copy Markdown

@ananya218 It would be very helpful if you can submit more detail about your pull request. From what I see, its moving JSON to the .gitignore, which doesn't seem too helpful, since .gitignore doesn't support JSON and this project uses Bower -- which you removed the configuration for. If you have an explanation, that would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants