Digest for Unmoderated Notes #7987

keshavsethi · 2020-06-04T09:29:34Z

Fixes #7986
This is a digest for unmoderated posts that go to admin and moderators and scheduled on a daily and weekly basis. For unmoderated posts status is "4" and it is taken as an argument in content_followed_in_period.
Please refer to following Screenshots and gif

For testing, spam digest button is added in /spam for daily digest.
Tests for this are left, I am working on that.
Please review @jywarren @SidharthBansal @pydevsg @ananyaarun @VladimirMikulic @cesswairimu @emilyashley @Uzay-G
Thanks!! ❤️ ✌️

codecov · 2020-06-04T09:32:31Z

Codecov Report

Merging #7987 into master will decrease coverage by 2.02%.
The diff coverage is 72.97%.

@@            Coverage Diff             @@
##           master    #7987      +/-   ##
==========================================
- Coverage   82.17%   80.15%   -2.03%     
==========================================
  Files          97       98       +1     
  Lines        5643     5698      +55     
==========================================
- Hits         4637     4567      -70     
- Misses       1006     1131     +125

Impacted Files	Coverage Δ
app/jobs/digest_spam_job.rb	`33.33% <33.33%> (ø)`
app/mailers/admin_mailer.rb	`97.40% <75.00%> (-2.60%)`	⬇️
app/models/user.rb	`90.80% <86.66%> (-0.25%)`	⬇️
app/controllers/admin_controller.rb	`78.33% <100.00%> (+0.27%)`	⬆️
app/controllers/stats_controller.rb	`73.62% <100.00%> (ø)`
app/channels/application_cable/channel.rb	`0.00% <0.00%> (-100.00%)`	⬇️
app/channels/application_cable/connection.rb	`0.00% <0.00%> (-100.00%)`	⬇️
app/channels/user_channel.rb	`0.00% <0.00%> (-83.34%)`	⬇️
app/channels/user_notification_channel.rb	`0.00% <0.00%> (-83.34%)`	⬇️
app/channels/room_channel.rb	`0.00% <0.00%> (-71.43%)`	⬇️
... and 13 more

Uzay-G · 2020-06-04T09:58:47Z

@keshavsethi could you please have a look at the codeclimate problems? thanks.

Uzay-G · 2020-06-04T13:44:21Z

app/controllers/admin_controller.rb

@@ -371,6 +371,11 @@ def queue
    end
  end

+  def test_digest_email_spam
+    DigestSpamJob.perform_async(0)


What does perform_async do here? Does it send the email in the background?

Yup, It is just for testing. It performs Job and creates Digest on daily basis. perform_async gets pushed to the Queue right away. 0 is for daily digest and 1 is for a weekly digest

Uzay-G · 2020-06-04T13:45:40Z

app/jobs/digest_spam_job.rb

@@ -0,0 +1,15 @@
+class DigestSpamJob
+  include Sidekiq::Worker
+  def perform(frequency_digest)


Later on we could maybe add a way for moderators to customize the frequency of their digest so that only those who want it will receive theirs.

Right now it just checks for tags digest:daily, digest:weekly, and if any of them is present then digest is sent. rn it tasks whatever is the settings of the moderator in the notification settings page. I will add more customization for moderators specifically for spam digest like frequency, type, and status (By tagging different tag like spam_digest:daily)
I was thinking of doing this on /spam2 and make the settings page there. But as of now, it is not merged. Should I add it to the current notification settings page for moderators??

app/models/user.rb

pydevsg

Good work @keshavsethi

jywarren · 2020-06-05T21:19:31Z

Wow, this is really cool! Thanks @keshavsethi !!

A couple questions - how does a user sign up for this, and/or change their settings?

And, would it be possible to write tests for this feature as part of this PR?

Thank you, very exciting!

keshavsethi · 2020-06-06T03:41:03Z

Wow, this is really cool! Thanks @keshavsethi !!

A couple questions - how does a user sign up for this, and/or change their settings?

And, would it be possible to write tests for this feature as part of this PR?

Thank you, very exciting!

Right now it automatically gets subscribed to all the moderators and admins as per their normal digest settings(like if they are opting of the weekly digest for following posts then they will get unmoderated posts as well in separate digest). I was thinking of adding more customization in spam2. Here It justs checks for digest:daily or digest:weekly tag. I can make a different tag for moderation digest like spam:digest weekly etc. I am working on tests, should I push it in the same PR??
Thanks!! 😄

keshavsethi · 2020-06-06T09:06:17Z

I made digest UI bit more refined and responsive, Please review.

app/controllers/admin_controller.rb

cesswairimu · 2020-06-07T22:45:53Z

app/models/user.rb

@@ -356,6 +373,19 @@ def send_digest_email
    end
  end

+  def send_digest_email_spam


Could you please add tests for these model methods?
Everything else looks good...great job 🎉

Sure, I will add it soon. Thanks!!

SidharthBansal · 2020-06-08T06:35:28Z

app/views/admin/spam.html.erb

@@ -10,6 +10,11 @@
    <li class="nav-item"><a class="nav-link <% if params[:action] == "spam_revisions" %> active <% end %>" href="/spam/revisions"><i class="fa fa-list"></i><span class="d-xs-inline d-md-none d-lg-inline"> Revisions</span></a></li>
    <li class="nav-item"><a class="nav-link <% if params[:action] == "spam_comments" %> active <% end %>" href="/spam/comments"><i class="fa fa-comment"></i><span class="d-xs-inline d-md-none d-lg-inline"> Comments</span></a></li>
    <li class="nav-item"><a class="nav-link" href="/people"><i class="fa fa-user"></i><span class="d-xs-inline d-md-none d-lg-inline"> Active Users</span></a></li>
+    <li class="nav-item">
+        <%= form_tag "/admin/test_digest_email_spam", method: :post do %>
+          <%= submit_tag "Test Spam Digest Email", class: "btn btn-sm btn-info", style: "width: 100%;" %>


Why is the name Test Spam Digest Email?
Also, please add corresponding tests in the PR.

This is a testing button just to test digest for 1-day unmoderated nodes. I have changed its position on the profile page where it is visible only to moderators. Name is Test Spam Digest Email because it is for tests and was in /spam and it creates email digest. I have added some tests. Please review. Thanks!!

cesswairimu

Looks good 🎉

keshavsethi · 2020-06-10T23:47:03Z

@jywarren @SidharthBansal @pydevsg @ananyaarun @VladimirMikulic @cesswairimu @emilyashley @Uzay-G If this fine, Can we please merge this?? 🙏

jywarren · 2020-06-11T20:50:06Z

test/unit/user_test.rb

@@ -305,4 +305,7 @@ class UserTest < ActiveSupport::TestCase
    end
  end

+  test 'Send digest email for unmoderated posts' do
+    assert users(:bob).send_digest_email_spam


Here, or in our functional tests, i wonder if we can check the content of the email itself to confirm? There are some other examples of this in our tests. It would help secure this feature against future issues!

jywarren · 2020-06-11T20:55:42Z

OK, so currently those tags are set in https://publiclab.org/settings - and I think we're OK to rely on that for this setting as well. But let's anticipate that people might in the future want to separate out moderation digest settings from regular content digests. As long as that isn't too much extra work, i think we could modify the text shown here (just for moderators/admins) to say:

Do you want to receive a weekly digest of content you follow [, as well as one for moderation emails]?

What do you think? Or would it be easier to just make a unique user tag like digest:moderation:weekly digest:moderation:daily?

Thank you, this is so great! Fantastic work!!! 🎉 🎉 🎉

keshavsethi · 2020-06-11T21:02:48Z

OK, so currently those tags are set in https://publiclab.org/settings - and I think we're OK to rely on that for this setting as well. But let's anticipate that people might in the future want to separate out moderation digest settings from regular content digests. As long as that isn't too much extra work, i think we could modify the text shown here (just for moderators/admins) to say:

Do you want to receive a weekly digest of content you follow [, as well as one for moderation emails]?

What do you think? Or would it be easier to just make a unique user tag like digest:moderation:weekly digest:moderation:daily?

Thank you, this is so great! Fantastic work!!!

@jywarren As mentioned in comment #7987 (comment)
Right now it automatically gets subscribed to all the moderators and admins as per their normal digest settings(like if they are opting of the weekly digest for following posts then they will get unmoderated posts as well in separate digest). I was thinking of adding more customization in spam2. Here It justs checks for digest:daily or digest:weekly tag. I can make a different tag for moderation digest like spam:digest weekly etc

jywarren · 2020-06-16T20:10:11Z

OK, yes, let's move to digest:moderation:weekly and digest:moderation:daily tags and corresponding UI settings -- would you be able to develop a unified PR with those distinct user tags and some UI on /settings to be able to switch those on and off too? Thank you @keshavsethi this is really awesome!

keshavsethi · 2020-06-16T22:17:18Z

OK, yes, let's move to digest:moderation:weekly and digest:moderation:daily tags and corresponding UI settings -- would you be able to develop a unified PR with those distinct user tags and some UI on /settings to be able to switch those on and off too? Thank you @keshavsethi this is really awesome!

Sure, I will work on its settings and tags, Thanks!

keshavsethi · 2020-06-22T13:53:20Z

Please refer to #8058. I have made some changes to this and updated it in #8058
Thanks!!

jywarren · 2020-07-07T13:53:44Z

Great, closing this one!

digest_spam

6071382

keshavsethi added 2 commits June 4, 2020 16:17

code_climate

cf2aeb5

refactoring

3012bb5

keshavsethi requested review from SidharthBansal, cesswairimu, jywarren, VladimirMikulic, ananyaarun, pydevsg and Uzay-G June 4, 2020 11:02

VladimirMikulic requested a review from nstjean June 4, 2020 13:07

Uzay-G reviewed Jun 4, 2020

View reviewed changes

app/models/user.rb Show resolved Hide resolved

keshavsethi changed the title ~~digest_spam~~ Digest for Unmoderated Notes Jun 4, 2020

pydevsg approved these changes Jun 5, 2020

View reviewed changes

Digest update

808374f

cesswairimu requested changes Jun 7, 2020

View reviewed changes

keshavsethi requested a review from Uzay-G June 8, 2020 02:37

SidharthBansal reviewed Jun 8, 2020

View reviewed changes

tests for spam digest

c53b596

keshavsethi requested a review from a team as a code owner June 8, 2020 23:38

cesswairimu approved these changes Jun 9, 2020

View reviewed changes

Uzay-G approved these changes Jun 11, 2020

View reviewed changes

jywarren reviewed Jun 11, 2020

View reviewed changes

keshavsethi mentioned this pull request Jun 16, 2020

Weekly Community Check-In #63 - Stay Updated! #8040

Closed

keshavsethi added this to the Spam! milestone Jun 16, 2020

keshavsethi mentioned this pull request Jun 22, 2020

Spam2: Digest for Unmoderated posts with settings #8058

Merged

jywarren changed the base branch from master to main June 30, 2020 18:17

jywarren closed this Jul 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Digest for Unmoderated Notes #7987

Digest for Unmoderated Notes #7987

keshavsethi commented Jun 4, 2020 •

edited

Loading

codecov bot commented Jun 4, 2020 •

edited

Loading

Uzay-G commented Jun 4, 2020

Uzay-G Jun 4, 2020

keshavsethi Jun 4, 2020

Uzay-G Jun 4, 2020

keshavsethi Jun 4, 2020

pydevsg left a comment

jywarren commented Jun 5, 2020

keshavsethi commented Jun 6, 2020

keshavsethi commented Jun 6, 2020

cesswairimu Jun 7, 2020

keshavsethi Jun 7, 2020

SidharthBansal Jun 8, 2020

keshavsethi Jun 8, 2020 •

edited

Loading

cesswairimu left a comment

keshavsethi commented Jun 10, 2020

jywarren Jun 11, 2020

jywarren commented Jun 11, 2020

keshavsethi commented Jun 11, 2020 •

edited

Loading

jywarren commented Jun 16, 2020

keshavsethi commented Jun 16, 2020

keshavsethi commented Jun 22, 2020

jywarren commented Jul 7, 2020

Digest for Unmoderated Notes #7987

Digest for Unmoderated Notes #7987

Conversation

keshavsethi commented Jun 4, 2020 • edited Loading

codecov bot commented Jun 4, 2020 • edited Loading

Codecov Report

Uzay-G commented Jun 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pydevsg left a comment

Choose a reason for hiding this comment

jywarren commented Jun 5, 2020

keshavsethi commented Jun 6, 2020

keshavsethi commented Jun 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keshavsethi Jun 8, 2020 • edited Loading

Choose a reason for hiding this comment

cesswairimu left a comment

Choose a reason for hiding this comment

keshavsethi commented Jun 10, 2020

Choose a reason for hiding this comment

jywarren commented Jun 11, 2020

keshavsethi commented Jun 11, 2020 • edited Loading

jywarren commented Jun 16, 2020

keshavsethi commented Jun 16, 2020

keshavsethi commented Jun 22, 2020

jywarren commented Jul 7, 2020

keshavsethi commented Jun 4, 2020 •

edited

Loading

codecov bot commented Jun 4, 2020 •

edited

Loading

keshavsethi Jun 8, 2020 •

edited

Loading

keshavsethi commented Jun 11, 2020 •

edited

Loading