-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Spam2: Digest for Unmoderated posts with settings #8058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8058 +/- ##
==========================================
- Coverage 82.49% 82.17% -0.33%
==========================================
Files 99 100 +1
Lines 5737 5773 +36
==========================================
+ Hits 4733 4744 +11
- Misses 1004 1029 +25
|
app/views/users/settings.html.erb
Outdated
@@ -90,6 +90,35 @@ | |||
<br /> | |||
<br /> | |||
|
|||
<% if current_user.can_moderate? %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, could we create a (maybe <h4>
bounded?) subsection for Moderation settings? That way it's a little easier to skim to the settings you want. Also, could we add a
in front of each instance of this phrase, for both existing and new settings? It's a little better grammatically:
weekly digest
=> a weekly digest
(and same for all others on this page?
Thank you @keshavsethi this is looking AMAZING!!! 🎉 🙌
@jywarren Please refer to this Screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super great. Thanks for doing this so thoroughly!
This is super! I'll be sure to mention this for staff; once it's live on the site, perhaps a brief blog post with this last screenshot could help introduce this new feature to folks on PublicLab.org? It'd be great to hear what they think! |
🎉 🎉 |
Here digest for unmoderated posts is added where I have used tag digest:daily:spam for daily digest and digest:weekly:spam for weekly digest. There is also a test button in the profile section which is used to generate the daily digest. Settings for this are only visible to moderators and admin. This PR is similar to #7987 with some additional changes like tags and settings.
Please refer to following Screenshots:



Please review @jywarren @cesswairimu @pydevsg @ananyaarun @ebarry @emilyashley @VladimirMikulic @Uzay-G
Thanks!