Skip to content

Spam2: Digest for Unmoderated posts with settings #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2020

Conversation

keshavsethi
Copy link
Member

Here digest for unmoderated posts is added where I have used tag digest:daily:spam for daily digest and digest:weekly:spam for weekly digest. There is also a test button in the profile section which is used to generate the daily digest. Settings for this are only visible to moderators and admin. This PR is similar to #7987 with some additional changes like tags and settings.

Please refer to following Screenshots:
Screenshot from 2020-06-22 18-50-06
Screenshot from 2020-06-22 18-49-34
Screenshot from 2020-06-22 18-49-51
Please review @jywarren @cesswairimu @pydevsg @ananyaarun @ebarry @emilyashley @VladimirMikulic @Uzay-G
Thanks!

@keshavsethi keshavsethi requested a review from a team as a code owner June 22, 2020 13:52
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #8058 into master will decrease coverage by 0.32%.
The diff coverage is 37.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8058      +/-   ##
==========================================
- Coverage   82.49%   82.17%   -0.33%     
==========================================
  Files          99      100       +1     
  Lines        5737     5773      +36     
==========================================
+ Hits         4733     4744      +11     
- Misses       1004     1029      +25     
Impacted Files Coverage Δ
app/controllers/users_controller.rb 82.29% <ø> (ø)
app/mailers/admin_mailer.rb 90.90% <12.50%> (-9.10%) ⬇️
app/models/user.rb 86.44% <12.50%> (-4.61%) ⬇️
app/jobs/digest_spam_job.rb 33.33% <33.33%> (ø)
app/controllers/admin_controller.rb 80.00% <100.00%> (-1.86%) ⬇️
app/controllers/spam2_controller.rb 100.00% <100.00%> (ø)
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@@ -90,6 +90,35 @@
<br />
<br />

<% if current_user.can_moderate? %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, could we create a (maybe <h4> bounded?) subsection for Moderation settings? That way it's a little easier to skim to the settings you want. Also, could we add a in front of each instance of this phrase, for both existing and new settings? It's a little better grammatically:

weekly digest => a weekly digest (and same for all others on this page?

Thank you @keshavsethi this is looking AMAZING!!! 🎉 🙌

@keshavsethi
Copy link
Member Author

keshavsethi commented Jun 23, 2020

Here, could we create a (maybe <h4> bounded?) subsection for Moderation settings? That way it's a little easier to skim to the settings you want. Also, could we add a in front of each instance of this phrase, for both existing and new settings? It's a little better grammatically:

weekly digest => a weekly digest (and same for all others on this page?

Thank you @keshavsethi this is looking AMAZING!!!

@jywarren Please refer to this Screenshot
Screenshot from 2020-06-24 04-42-54
I have added a subsection for this and added a in some lines. Please review.
Thanks!!

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super great. Thanks for doing this so thoroughly!

@jywarren jywarren merged commit c60aaab into publiclab:master Jun 30, 2020
@jywarren
Copy link
Member

This is super! I'll be sure to mention this for staff; once it's live on the site, perhaps a brief blog post with this last screenshot could help introduce this new feature to folks on PublicLab.org? It'd be great to hear what they think!

@cesswairimu
Copy link
Collaborator

🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants