missing unit/integration tests#139
Merged
Merged
Conversation
jguz-pubnub
reviewed
Sep 4, 2025
| uuidIds.add(uuid); | ||
|
|
||
| // Small delay to avoid overwhelming the service | ||
| if (i % 10 == 9) { |
There was a problem hiding this comment.
Is this delay required? Is there any consequence of not having it in place?
Contributor
Author
There was a problem hiding this comment.
due to flakiness in tests result that delay was added
Still, Let me check what we see by removing that delay. I'll run through multiple iteration. If not needed then better to remove it.
Contributor
Author
There was a problem hiding this comment.
removed delays as test looks fine without that delays
jguz-pubnub
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test enhancement across apis