-
Notifications
You must be signed in to change notification settings - Fork 7
Add form switcher #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add form switcher #1160
+1,501
−935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13ee081
to
8948d60
Compare
f3c9d0e
to
87cecc5
Compare
a6adb69
to
ff6774d
Compare
5719a72
to
28d6c2a
Compare
3252290
to
27d51b4
Compare
27d51b4
to
05289b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Resolves #1037
Resolves #1036
High-level Explanation of PR
This PR adds the form switcher component to forms and the pub details page, and fully implements the new form permissions introduced in #1134.
temporary/
prefix initially, then move them to the pubId based path after the form is submitted and the pub is created. To avoid orphaned files, I've added a lifecycle policy to deletetemporary/
files after 90 days.Test Plan
Screenshots (if applicable)
Notes