Skip to content

Fix order dependent test failures #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bess wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix order dependent test failures #2273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3de3c24
WIP: Fix flaky test
bess Dec 3, 2025
0bb942e
[skip ci] Merge branch 'main' into i2261-flaky-test
bess Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions spec/system/project_index_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
let(:request2) { FactoryBot.create(:request_project, project_title: "orange pop") }
let(:request3) { FactoryBot.create(:request_project, project_title: "grape soda") }

let!(:project1) { create_project_in_mediaflux(request: request1, current_user: current_user) }
let!(:project2) { create_project_in_mediaflux(request: request2, current_user: current_user) }
let!(:project3) { create_project_in_mediaflux(request: request3, current_user: current_user) }
let(:project1) { create_project_in_mediaflux(request: request1, current_user: current_user) }
let(:project2) { create_project_in_mediaflux(request: request2, current_user: current_user) }
let(:project3) { create_project_in_mediaflux(request: request3, current_user: current_user) }

after do
Mediaflux::AssetDestroyRequest.new(session_token: current_user.mediaflux_session, collection: project1.mediaflux_id, members: true).resolve
Expand All @@ -44,6 +44,20 @@
end

before do
# Ensure projects are re-created in Mediaflux. We're getting intermittent test failures b/c sometimes the
# projects already exist in Mediaflux from a previous test run.
request1.destroy
request2.destroy
request3.destroy
Mediaflux::AssetDestroyRequest.new(session_token: current_user.mediaflux_session, collection: project1.mediaflux_id, members: true).resolve
Mediaflux::AssetDestroyRequest.new(session_token: current_user.mediaflux_session, collection: project2.mediaflux_id, members: true).resolve
Mediaflux::AssetDestroyRequest.new(session_token: current_user.mediaflux_session, collection: project3.mediaflux_id, members: true).resolve
request1
request2
request3
project1
project2
project3
sign_in current_user
project_not_in_mediaflux
end
Expand Down