Remove two small just-added tests#1188
Conversation
dralley
force-pushed
the
remove-legacy
branch
7 times, most recently
from
e65e9e1 to
cc40bdd
Compare
|
|
||
| from packaging.version import parse | ||
|
|
||
| if parse(click.__version__) < parse("8.1.1") or parse(click.__version__) >= parse("8.2"): |
There was a problem hiding this comment.
click 8.2 was just released, our pyproject.toml only requests for <9, so this fails now
There was a problem hiding this comment.
"This is the Click 8.2.0 feature release. A feature release may include new features, remove previously deprecated code, add new deprecation, or introduce potentially breaking changes."
AKA we don't use semver... AAAARGH
There was a problem hiding this comment.
tbf they didn't actually remove it, but the warning alone caused our CI to fail
|
Not sure what's up with the unittests |
|
Well, it's nothing to do with my branch, it's a nightly issue https://github.com/pulp/pulp-cli/actions/runs/14963198913/job/42028538329 |
We decided on a different behavior, no-op instead of outright failure.
Backport to 0.32: 💚 backport PR created✅ Backport PR branch: Backported as #1195 🤖 @patchback |
2 participants
We decided on a different behavior, no-op instead of outright failure.