Refactor viewset repo modify code #4250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
refactor-modify-action
branch
2 times, most recently
from
a06558b to
6fb948f
Compare
Contributor
Author
|
Tests are failing since pulp/pulpcore#7185 has not been merged but this should be ready for review. |
dralley
approved these changes
Jan 8, 2026
Contributor
|
We can likely retest next week once 3.101 is out - the CI would need this to be present in a released build of pulpcore. |
Contributor
|
Doesn't this need to up the core-LB in pyproject to 101 then? Since it's relying on a feature that isn't in <=3.100? |
daviddavis
force-pushed
the
refactor-modify-action
branch
from
6fb948f to
09f46c3
Compare
Contributor
Author
|
Yes, good catch. Updated the lower bound. |
daviddavis
force-pushed
the
refactor-modify-action
branch
2 times, most recently
from
f4141be to
e5def4f
Compare
This change relies on pulp/pulpcore#7185 to remove much of the duplicate code for the modify action.
daviddavis
force-pushed
the
refactor-modify-action
branch
from
e5def4f to
962f20c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change relies on pulp/pulpcore#7185 to specify the
modify_actionand remove the duplicate code for the modify action.