Skip to content

README tweaks#1

Open
ehershey wants to merge 1 commit into
pulse-vadc:masterfrom
ehershey:patch-1
Open

README tweaks#1
ehershey wants to merge 1 commit into
pulse-vadc:masterfrom
ehershey:patch-1

Conversation

@ehershey
Copy link
Copy Markdown

@ehershey ehershey commented Feb 8, 2019

The examples are super helpful and this makes them easier to run.

The examples are super helpful and this makes them easier to run.
@ndavidson-pulse
Copy link
Copy Markdown
Contributor

Hi Ernie and thanks for your help!

You'll have to be patient with us as we haven't yet sorted out how we want to deal with contributions so it may take a little while to accept your pull request.

@ehershey
Copy link
Copy Markdown
Author

Okay, no problem. Thanks for replying! There are a handful of other changes I'd probably also contribute if there's a way to do it.

@ndavidson-pulse
Copy link
Copy Markdown
Contributor

@ehershey Actually your post has reminded me, providing you're happy to license your contribution under the MPL 2.0 - the license for all the Pulse authored source code in the repository, we're happy to accept your contribution.

@ehershey
Copy link
Copy Markdown
Author

Yep, fine with me! Do I need to do that formally somehow?

@ndavidson-pulse
Copy link
Copy Markdown
Contributor

Nope we should be good with your commentary on this issue.

@rafi0101
Copy link
Copy Markdown

Hello @ehershey,
maybe you can add contactable and contactErr as return values, because with version 8.3 this is required.

Hello @ndavidson-pulse and @pillalamarriramana,
can you please accept the pull request. Since the current instructions in your main readme.md no longer work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants