chore: also test with PHP 8.3 #1435
Conversation
Copied from https://github.com/nextcloud/coding-standard/blob/af952f469a320200b89ab529205c63a861d35308/src/Config.php I basically added all rules that php-cs-fixer wanted to apply to the files with the previous config AND that have an explicit rule in the NC coding standards repository. The goal was to being as close to the NC coding standard as possible without entirely coping it (for now).
|
All I wanted was to extend test coverage to current PHP and NC versions, but in order to get PHP 8.3 support, I needed to update php-cs-fixer from 3.35 to 3.75. In those updates, php-cs-fixer has added an awful amount of new rules, so this ended in a formatting war. I don't know how opinioned you are about formatting @pulsejet, and what your preferences are. Personally, I don't care that much when tools do the formatting job anyway. I would suggest to just adopt whatever https://github.com/nextcloud/coding-standard/blob/master/src/Config.php is doing to have consistency with other Nextcloud code. I will probably split out NC 31 CI coverage to another pull request to get that part of it faster in a mergeable state. |
|
I have splitted out test coverage for NC 31: #1436 |
Croydon
changed the title
Why?
Test with all current NC versions + all PHP versions that are supported by all NC versions
https://github.com/nextcloud/server/wiki/Releases-and-PHP-versions