Make Memories compatible with Nextcloud 33

[szaimen]

• Close Storage\Root folder not found following NC 33 update. #1626
• Close Support Nextcloud 33 & Preview Table Migration Compatibility Request #1618
• Close Make app compatible with NC 33 aka NC 26 Hub Winter #1625

[invario]

Checked out your PR on my dev setup of 33.0.1 RC1. Appears to be working, although I only have a few media files on this instance.

Thank you!

edit: I populated this instance with about 500 files, looks okay to me!

[starypatyk]

Hi @szaimen

Thanks for your changes to make memories compatible with NC33. 👍 I have checked out your PR in my dev NC33 setup and memories work fine with these changes.

However, I have noticed that with these changes the multipreview endpoint /apps/memories/api/image/multipreview does not return any data. Memories work by getting the previews using a fall-back path - i.e. getting the previews for each file individually using the /apps/memories/api/image/preview/<file_id> API endpoint.

If I understand correctly, the reason for this is that the old AppData mechanism (based on the oc_filecache table) in NC33 no longer returns information about the previews and memories cannot find the -max preview files as in previous versions of NC.

I have prepared an alternative implementation of the multipreview method that uses the new OC\Preview\PreviewService class to retrieve data about the existing previews from the new oc_previews table - see this commit:
starypatyk@d02e21f

With this change the multipreview endpoint seems to return proper data, and the memories app no longer needs to fetch the previews individually.

Please feel free to use this change in your PR, if you think that my analysis is correct.

PS. I think that my initial implementation could be optimized further by invoking the getAvailablePreviews for all provided file IDs - rather than invoking getAvailablePreviewsForFile separately for each requested file ID.

[Bono-Boy]

I truly love the memories app when using on nextcloud 32. But now i have 33. But i don't understand how to add this fix.
Do i first need to install the app by allowing the untested app 7.8.2 and afterwards apply the fix?
Sorry for the N00B question. BTW. Using truenas scale with nextcloud as docker app installed.

[EVOTk]

I truly love the memories app when using on nextcloud 32. But now i have 33. But i don't understand how to add this fix. Do i first need to install the app by allowing the untested app 7.8.2 and afterwards apply the fix? Sorry for the N00B question. BTW. Using truenas scale with nextcloud as docker app installed.

If you're not comfortable with that, it's best to wait until @pulsejet is available and releases a new version of the app :)

[Croydon]

The issue #1618 also mentions the changed Recognize API. Should we open a new issue for that so it isn't forgotten?

[starypatyk]

@szaimen - follow-up to my previous comment.

Optimized version - using getAvailablePreviews with all provided file IDs here:
starypatyk@15cece6

Tested briefly in my dev environment - seems to behave as expected.

PS. I plan to dig into refreshPreviews next.