Skip to content

Updating component resource to be a more complete picture #14675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Apr 4, 2025

Proposed changes

**This pull request includes updates to the documentation and examples for creating a child resource and registering component outputs in multiple programming languages. Additionally, a new guidance file for Claude Code has been added.

Documentation Updates:

New Guidance File:

  • CLAUDE.md: Added a new file providing guidance to Claude Code (claude.ai/code) for working with code in this repository. It includes build/test/lint commands and code style guidelines.**

Unreleased product version (optional)

Related issues (optional)

@rshade rshade requested a review from a team as a code owner April 4, 2025 20:37
@pulumi-bot
Copy link
Collaborator

@rshade rshade force-pushed the rshade/componentenhance branch from 3a71735 to 76f0da9 Compare April 7, 2025 15:52
@pulumi-bot
Copy link
Collaborator

@rshade rshade requested a review from jdavredbeard April 7, 2025 19:34
@thoward thoward enabled auto-merge (squash) May 15, 2025 03:19
@thoward
Copy link
Contributor

thoward commented May 15, 2025

LGTM, pending code review from team. Enabled auto-merge for whenever that's complete. Big ups for adding the CLAUDE.md and wish we'd have gotten this in here earlier. I went ahead and merged w/ existing CLAUDE.md on master, which was added recently by @jkodroff .

@pulumi-bot
Copy link
Collaborator

@rshade rshade force-pushed the rshade/componentenhance branch from 9e14bd1 to e9b38c5 Compare May 16, 2025 14:55
@pulumi-bot
Copy link
Collaborator

@rshade rshade force-pushed the rshade/componentenhance branch from e9b38c5 to 1455172 Compare June 2, 2025 21:35
@pulumi-bot
Copy link
Collaborator

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thoward thoward merged commit 532ac96 into master Jun 3, 2025
8 checks passed
@thoward thoward deleted the rshade/componentenhance branch June 3, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants