Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Subdomain Computation of Util function #1629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Armadillidiid
Copy link

The getDomainAndSubdomain function previously incorrectly computed the subdomain for domain names with multiple subdomains. This commit fixes the computation by properly iterating over the domain parts to extract the subdomain. Additionally, it adds a trailing dot to the parent domain for canonicalization.

The getDomainAndSubdomain function previously incorrectly computed the subdomain for domain names with multiple subdomains. This commit fixes the computation by properly iterating over the domain parts to extract the subdomain. Additionally, it adds a trailing dot to the parent domain for canonicalization.
Copy link

github-actions bot commented Apr 9, 2024

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant