Fix secret sanitizing for non string values #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas11
approved these changes
Oct 20, 2024
Contributor
thomas11
left a comment
thomas11
left a comment
There was a problem hiding this comment.
Workflow failure due to my recent change in #3651 but otherwise LGTM
- Use callback instead of fixed value for secret replacement. - Find all strings recursively in JSON objects for replacement. - Handle difference between gRPC using "value" and state using a "plaintext" string.
danielrbradley
force-pushed
the
fix-recursive-sanitize
branch
from
3a9f4c8 to
9629e95
Compare
|
This PR has been shipped in release v0.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108