Failed test cleanup usability improvements #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
approved these changes
Oct 21, 2024
Member
iwahbe
left a comment
iwahbe
left a comment
There was a problem hiding this comment.
I think the change itself is good.
I'd like to see a less messy way to handle env vars. We don't need to block on it, but I think the cleanup would be worth it.
- Print instructions on how to retain resources on failure. - When retaining resources explain why this is happening and write out a destroy script for the user to run once they've finished their investigations. Related to #109
- Maintain existing defaults - keeping locally. - Add explicit control via PULUMITEST_RETAIN_FILES_ON_FAILURE with prompting to the user on failure. - Default to retaining if we've retained the resources. - Finally, check for the `CI` env var.
danielrbradley
force-pushed
the
stack-cleanup-help
branch
from
8744df7 to
f53ddab
Compare
|
This PR has been shipped in release v0.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make cleaning up stacks easier
Related to #109
Make temp directory cleanup easier to control
CIenv var.