Add handshake GRPC method replay #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
reviewed
Dec 16, 2024
Member
iwahbe
left a comment
iwahbe
left a comment
There was a problem hiding this comment.
Looks like some tests need to be updated here.
t0yv0
approved these changes
Dec 16, 2024
Member
t0yv0
left a comment
t0yv0
left a comment
There was a problem hiding this comment.
Seems reasonable - approving so you can merge once you finish fighting CI.
|
This PR has been shipped in release v0.1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to replay Handshake GRPC methods with the replay test framework. Handshake is a new engine GRPC method.