Skip to content

Conversation

@thomas11
Copy link
Contributor

Currently, a failing preview in a test just shows as something like

azure-native:storage:Blob myBlobFile create replacement [diff: ~source]

which is not as helpful as it could be diagnose the problem because you don't know what the diff is.

We could expose a flag for an optional diff in optproviderupgrade but since this is a testing library, I suggest we skip this boilerplate and just turn the diff always on - when would you not want to see the diff on test failure?

With this change:

            +-azure-native:storage:Blob: (replace)
                [id=/subscriptions/0282681f-7a9e-424b-80b2-96babd57a8a1/resourceGroups/rg1c1afbc6/providers/Microsoft.Storage/storageAccounts/store16dfec76/blobServices/default/containers/assets/blobs/mon-fichier.txt]
                [urn=urn:pulumi:test::upgrade-storage-blob::azure-native:storage:Blob::myBlobFile]
              - source: [secret]
              + source: asset(text:678e7ad) {
                    <contents elided>
                }

@thomas11 thomas11 requested review from a team and danielrbradley January 15, 2025 10:20
@thomas11 thomas11 force-pushed the tkappler/preview-diff branch from bc9f8e1 to 1c3d625 Compare January 15, 2025 10:29
Copy link
Contributor

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending removal of user settings.

@thomas11 thomas11 merged commit ec5389a into main Jan 15, 2025
2 checks passed
@thomas11 thomas11 deleted the tkappler/preview-diff branch January 15, 2025 10:47
@pulumi-bot
Copy link

This PR has been shipped in release v0.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants