Skip partial log entries when replaying gRPC logs #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
approved these changes
Nov 5, 2025
blampe
added a commit
that referenced
this pull request
Nov 20, 2025
Followup to #157. This omits partial log entries from the raw gRPC log, which some providers inspect as part of tests. A test was made to fail in order to confirm the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change pulumi/pulumi#20817 in the Pulumi CLI, the log entries are now logged twice, once when a request is started and another time when we get response. That means we can't replay gRPC logs that contain request data, we need both request and response data, hence this PR skipping partial log entries cc @iwahbe