Automated upgrade: bump pulumi/pulumi to 3.230.0#2908
Automated upgrade: bump pulumi/pulumi to 3.230.0#2908pulumi-bot wants to merge 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Automated upgrade PR looks good. All changes are consistent with bumping pulumi/pulumi from v3.225.0 to v3.230.0:
- Go modules (
sdk/go.mod, examples, testdata): routine transitive dependency bumps accompanying the SDK version change. - Java SDK (
settings.gradle):include("lib")removal is safe — nolibsubdirectory exists insdk/javaat HEAD. - Node.js SDK (
package.json,tsconfig.json): Themodule: "nodenext"/moduleResolution: "nodenext"shift in the generated tsconfig is the most visible change. Sincepackage.jsonhas no"type": "module", all.tsfiles are treated as CJS under nodenext semantics; extensionless relative imports remain valid and output format is unchanged. The additions ofdeclarationMap: true,skipLibCheck: true, andnoImplicitReturns: trueare improvements.
One non-blocking note left inline about the typescript: "^4.7.0" floor — worth revisiting in the upstream codegen templates.
Reviewed by Internal Trusted PR Reviewer
To install this agentic workflow, run
gh aw add pulumi-labs/gh-aw-internal/.github/workflows/gh-aw-pr-review.md@99a309bf18258dbae98c8176ea10657e0b08deca
| "experimentalDecorators": true, | ||
| // Environment | ||
| "target": "ES2022", | ||
| "module": "nodenext", |
There was a problem hiding this comment.
Non-blocking: Switching to module: "nodenext" / moduleResolution: "nodenext" is safe here because package.json has no "type": "module" field — TypeScript will still emit CommonJS and extensionless relative imports remain valid under CJS nodenext semantics.
One minor follow-up worth tracking: the companion typescript: "^4.7.0" in package.json sets the floor at TypeScript 4.7, which first introduced nodenext support but had some rough edges. A higher floor (e.g., ^5.0.0) would be more robust in practice, though since this is generated code the upstream templates control the value.
Automated upgrade: bump pulumi/pulumi to 3.230.0