Skip to content

Correct a typo in VpcEndpointServiceAllowedPrinciple #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct a typo in VpcEndpointServiceAllowedPrinciple #5396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions provider/cmd/pulumi-resource-aws/bridge-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162827,6 +162827,17 @@
}
},
"aws_vpc_endpoint_service_allowed_principal": {
"current": "aws:ec2/vpcEndpointServiceAllowedPrincipal:VpcEndpointServiceAllowedPrincipal",
"past": [
{
"name": "aws:ec2/vpcEndpointServiceAllowedPrinciple:VpcEndpointServiceAllowedPrinciple",
"inCodegen": true,
"majorVersion": 6
}
],
"majorVersion": 6
},
"aws_vpc_endpoint_service_allowed_principal_legacy": {
"current": "aws:ec2/vpcEndpointServiceAllowedPrinciple:VpcEndpointServiceAllowedPrinciple",
"majorVersion": 6
},
Expand Down Expand Up @@ -279041,6 +279052,11 @@
"source": true
}
},
"aws_vpc_endpoint_service_allowed_principal": {
"aliases": [
"aws:ec2/vpcEndpointServiceAllowedPrinciple:VpcEndpointServiceAllowedPrinciple"
]
},
"aws_wafv2_web_acl": {
"maxItemsOneOverrides": {
"association_config.$.request_body.$.api_gateway": false,
Expand Down Expand Up @@ -279611,6 +279627,7 @@
"aws:ec2/vpcEndpointPolicy:VpcEndpointPolicy": 0,
"aws:ec2/vpcEndpointRouteTableAssociation:VpcEndpointRouteTableAssociation": 0,
"aws:ec2/vpcEndpointService:VpcEndpointService": 0,
"aws:ec2/vpcEndpointServiceAllowedPrincipal:VpcEndpointServiceAllowedPrincipal": 0,
"aws:ec2/vpcEndpointServiceAllowedPrinciple:VpcEndpointServiceAllowedPrinciple": 0,
"aws:ec2/vpcEndpointSubnetAssociation:VpcEndpointSubnetAssociation": 0,
"aws:ec2/vpcIpam:VpcIpam": 0,
Expand Down
2 changes: 1 addition & 1 deletion provider/cmd/pulumi-resource-aws/runtime-bridge-metadata.json
View file
Open in desktop

Large diffs are not rendered by default.

64 changes: 62 additions & 2 deletions provider/cmd/pulumi-resource-aws/schema.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 10 additions & 0 deletions provider/resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5652,6 +5652,16 @@ compatibility shim in favor of the new "name" field.`)
prov.Resources[k] = v
}

// Correct a typo: Principle -> Principal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe you actually need this. I believe that if you edit the definition in resources.go above you'd get the right thing since we have AutoAliasing and the old name is saved in the bridge-metadata

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a human is doing it it sounds better to have it explicit tbh.

prov.RenameResourceWithAlias(
"aws_vpc_endpoint_service_allowed_principal", /*resourceName*/
awsResource(ec2Mod, "VpcEndpointServiceAllowedPrinciple"), /*legacyTok*/
awsResource(ec2Mod, "VpcEndpointServiceAllowedPrincipal"), /*newTok*/
ec2Mod, /*legacyModule*/
ec2Mod, /*newModule*/
prov.Resources[string(awsResource(ec2Mod, "VpcEndpointServiceAllowedPrinciple"))],
)

prov.MustComputeTokens(tks.MappedModules("aws_", "", moduleMap,
func(mod, name string) (string, error) {
return awsResource(mod, name).String(), nil
Expand Down
146 changes: 146 additions & 0 deletions sdk/dotnet/Ec2/VpcEndpointServiceAllowedPrincipal.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion sdk/dotnet/Ec2/VpcEndpointServiceAllowedPrinciple.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions sdk/go/aws/ec2/init.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading