[7.0.0-alpha]: upgrade upstream to 6.0.0-beta #5479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Found 376 breaking changes: Resources
Functions
Types
New resources:
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.0.0-alpha #5479 +/- ##
==============================================
Coverage ? 24.26%
==============================================
Files ? 359
Lines ? 143766
Branches ? 0
==============================================
Hits ? 34890
Misses ? 108782
Partials ? 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
corymhall
force-pushed
the
corymhall/upstream-v6-beta
branch
from
5af0391 to
35c777f
Compare
|
This change is part of the following stack: Change managed by git-spice. |
corymhall
force-pushed
the
corymhall/upstream-v6-beta
branch
from
f805d00 to
bac397f
Compare
corymhall
changed the title
corymhall
commented
May 8, 2025
| @@ -1049,43 +1039,6 @@ func TestRegress4446(t *testing.T) { | |||
| t.Logf("#%v", result.ChangeSummary) | |||
| } | |||
|
|
|||
| func TestRegress4568(t *testing.T) { | |||
There was a problem hiding this comment.
This tested a patch which is now removed.
| @@ -1017,21 +1022,6 @@ func TestRegress4128(t *testing.T) { | |||
| integration.ProgramTest(t, &test) | |||
| } | |||
|
|
|||
| func TestGameLift(t *testing.T) { | |||
There was a problem hiding this comment.
Gamelift patch removed.
| @@ -187,6 +187,24 @@ func TestElasticacheReplicationGroupUpgrade(t *testing.T) { | |||
| testProviderUpgrade(t, filepath.Join("test-programs", "elasticache-replication-group"), nil) | |||
| } | |||
|
|
|||
| func TestS3BucketToBucketUpgrade(t *testing.T) { | |||
There was a problem hiding this comment.
Added these two tests which test both types of upgrades.
Bucket (legacy) => BucketBucketV2 => Bucket
| @@ -1959,15 +1912,3 @@ func TestSecurityGroupPreviewWarning(t *testing.T) { | |||
| assert.NotContains(t, prev.StdOut, "warning: Failed to calculate preview for element") | |||
| assert.NotContains(t, prev.StdErr, "warning: Failed to calculate preview for element") | |||
| } | |||
|
|
|||
| func TestBucketToBucketV2Alias(t *testing.T) { | |||
There was a problem hiding this comment.
This was moved to an upgrade test
| @@ -0,0 +1,87 @@ | |||
| import * as aws from "@pulumi/aws"; | |||
There was a problem hiding this comment.
I was working on creating an upgrade test for the job-queue upgrade, but I couldn't get it to work. Postponing to a follow up task.
This was referenced May 8, 2025
VenelinMartinov
approved these changes
May 12, 2025
|
I'm having a hard time using the Github UI here but I think some of the aliases in "aws_s3_bucket_object_lock_configuration": {
Tok: awsResource(s3Mod, "BucketObjectLockConfiguration"),
Aliases: []tfbridge.AliasInfo{
{Type: ref("aws:s3/bucketObjectLockConfiguration:BucketObjectLockConfiguration")},
},
},
"aws_s3_bucket_request_payment_configuration": {
Tok: awsResource(s3Mod, "BucketRequestPaymentConfiguration"),
Aliases: []tfbridge.AliasInfo{
{Type: ref("aws:s3/bucketRequestPaymentConfigurationV2:BucketRequestPaymentConfigurationV2")},
},
},
"aws_s3_bucket_server_side_encryption_configuration": {
Tok: awsResource(s3Mod, "BucketServerSideEncryptionConfiguration"),
Aliases: []tfbridge.AliasInfo{
{Type: ref("aws:s3/bucketServerSideEncryptionConfiguration:BucketServerSideEncryptionConfiguration")},
},
},
"aws_s3_bucket_versioning": {
Tok: awsResource(s3Mod, "BucketVersioning"),
Aliases: []tfbridge.AliasInfo{
{Type: ref("aws:s3/bucketVersioning:BucketVersioning")},
},
},
"aws_s3_bucket_website_configuration": {
Tok: awsResource(s3Mod, "BucketWebsiteConfiguration"),
Aliases: []tfbridge.AliasInfo{
{Type: ref("aws:s3/bucketWebsiteConfiguration:BucketWebsiteConfiguration")},
},I believe you meant to have V2 on all of these. @corymhall |
Good catch!
Yep i'll create follow ups for all of these things. Wanted to get the reviews before so I didn't create any issues prematurely. |
guineveresaenger
approved these changes
May 12, 2025
There are two main breaking changes in this update. 1. If resource tags are removed _and_ the keys that are removed also exist in `DefaultTags` _with a value of ""_, then they will not be updated related to [#37297](hashicorp/terraform-provider-aws#37297) - Created a follow up issue #5517 2. `tags` and `tagsAll` are now separate things. Previously we set `tags`=`tagsAll` so `tags` always included _all_ the tags. Now only `tagsAll` will contain all tags. I kept some of our customization on the Pulumi side to deal with a Pulumi only issue. For sdkv2 resources, if you are removing `defaultTags` then the `tagsAll` attribute will only be updated when: - `pulumi refresh --run-program` with the changes to defaultTags - `pulumi up` to propagate the changes
This starts the docs to keep track of breaking changes that are being made to v7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a major version upgrade while upgrading upstream to the
release/6.0.0-betabranch.Some things that occur as part of this major version upgrade are:
MaxItemsOnethat were held off in v6 occur nowIn additional the following groups of patches were removed. This was included in this PR rather than in a follow up because as part of the
6.0.0-betaupstream completely removed aws sdkv1. In order to keep these patches around we would have had to either include it back or update the patches to use aws sdkv2.Remove sdkv1 related patches
closes PATCH 0046-restore-ecr-NewConn.patch #5461, closes PATCH 0088-restore-conns-to-awsclient.patch #5460, closes PATCH 0026-Restore-S3ConnURICleaningDisabled.patch #5465, closes PATCH 0071-Restore-conns-factory-for-SDKv1-Go-clients-used-by-patches #5463, closes Upgrade legacy bucket patches to aws sdkv2 #5470, closes PATCH Restore-AWS-Go-SDK-v1-session.patch #5472
Legacy S3 Bucket Patches
closes PATCH 0039-Restore-legacy-bucket.patch #3720, closes PATCH 0044-fix-legacy-bucket-context.patch #3726, closes PATCH 0003-Add-S3-legacy-bucket-to-resources.patch #2727, closes PATCH 0004-Marks-SSE-Configuration-as-Computed-for-Legacy-S3-Bu.patch #2728, closes PATCH Legacy-bucket-Read-now-sets-acl-and-force_destroy-de.patch #5474, closes PATCH 0025-Match-the-tags-behavior-of-other-resources.patch #2752, closes PATCH De-deprecate-bucket_object.patch #2729
Remove deprecated Gamelift MatchMaking resources
closes PATCH 0091-patch-gamelift-tags-back.patch #5409, closes PATCH 0018-Fixup-gamelift-context.patch #2745, closes PATCH 0016-Reverts-patches-to-S3BucketLegacy-and-GameLift.patch #2742, closes PATCH 0015-add-matchmaking-configuration-72.patch #2740, closes PATCH 0060-Fix-resourceMatchmakingConfigurationUpdate.patch #5467, closes PATCH 0064-Adapt-gamelift-matchmaking-resources.patch #5468, closes PATCH 0070-Adjust-matchmaking_configuration-resource-IgnoreTags.patch #5469
There are a lot of changes in this PR that I won't be able to enumerate in this description so I have created a follow up PR that includes a doc with all the details. #5498
closes #2732