Skip to content

Add Node.js 24, drop 18 #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/matrix/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
# The additional versions are used for the suffixed images `pulumi-python-3.10`, `pulumi-python-3.11`, ...
versioned = {
"nodejs": {
"default": "22",
"additional": ["18", "20", "23"]
"default": "24",
"additional": ["20", "22", "23"]
},
"python": {
"default": "3.12",
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Unreleased

- Support Node.js 24
([#464](https://github.com/pulumi/pulumi-docker-containers/pull/464))

## 3.167.0

- Update corepack
([#391](https://github.com/pulumi/pulumi-docker-containers/pull/391))
- Drop .NET 6.0 container
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Images without a version suffix use the following language versions by default:
- .NET 8.0
- Go 1.24
- JDK 21
- Node.js 22
- Node.js 24
- Python 3.12

### Version Policy
Expand Down
6 changes: 3 additions & 3 deletions docker/pulumi/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,11 @@ RUN curl -fsSL https://fnm.vercel.app/install | bash -s -- --install-dir "/usr/l
ENV FNM_COREPACK_ENABLED="true"
ENV FNM_VERSION_FILE_STRATEGY="recursive"
ENV FNM_DIR=/usr/local/share/fnm
RUN fnm install 18 && \
fnm install 20 && \
RUN fnm install 20 && \
fnm install 22 && \
fnm install 23 && \
fnm alias 22 default
fnm install 24 && \
fnm alias 24 default
ENV PATH=/usr/local/share/fnm/aliases/default/bin:$PATH
RUN npm install -g corepack && \
corepack install -g pnpm yarn
Expand Down
1 change: 0 additions & 1 deletion tests/testdata/node-18/.node-version

This file was deleted.

1 change: 1 addition & 0 deletions tests/testdata/node-24/.node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
24
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ const version = semver.parse(process.version, {
loose: true
});

if (version?.major != 18) {
throw new Error(`Expected node version 18.x.x, got ${process.version}`);
if (version?.major != 24) {
throw new Error(`Expected node version 24.x.x, got ${process.version}`);
}
4 changes: 2 additions & 2 deletions tests/testdata/node-default/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ const version = semver.parse(process.version, {
loose: true
});

if (version?.major != 22) {
throw new Error(`Expected node version 22.x.x, got ${process.version}`);
if (version?.major != 24) {
throw new Error(`Expected node version 24.x.x, got ${process.version}`);
}
Loading