Catch errors in tests of the kitchen sink image - #495
Conversation
julienp
added
the
impact/no-changelog-required
| @@ -163,7 +163,8 @@ jobs: | |||
| run: | | |||
There was a problem hiding this comment.
Hrm I guess we didn't catch the errors because of the piping? Not sure why pipefail doesn't fix that. I wonder though, should these just be two test targets, "Tests root" and "Tests nonroot"? Then we don't need any piping to change the output, and less shell magic to wait for processes etc.
There was a problem hiding this comment.
The reason for the backgrounding is that we want the 2 tests to run in parallel. I guess we could just matrix it out.
There was a problem hiding this comment.
Ah I remember the reason why I didn't go with a matrix, it means we have to build the image twice. Oh well, it will happen in parallel, so it should be fine.
ad6aebd to
ba2a173
Compare
ba2a173 to
fd03861
Compare
| -test.parallel=8 -test.timeout=1h -test.v | sed 's/.*/[root] &/' & | ||
| docker run \ | ||
| -e RUN_CONTAINER_TESTS=true \ | ||
| -e IMAGE_VARIANT=pulumi-nonroot \ |
There was a problem hiding this comment.
Need to use matrix.variant for this
While looking into pulumi/templates#929 I noticed that the kitchen sink job was not failing https://github.com/pulumi/pulumi-docker-containers/actions/runs/15796277766/job/44529555986#step:16:1064
ebd58d6 to
86d2890
Compare
86d2890 to
42634f5
Compare
2 participants
While looking into pulumi/templates#929 I noticed that the kitchen sink job was not failing https://github.com/pulumi/pulumi-docker-containers/actions/runs/15796277766/job/44529555986#step:16:1064 when it should have run into the same bug. The tests actually do fail, but our setup hides that from CI.
To fix this we run a matrix on the variant: normal and non root.
Also fixes the image name for the
nonrootvariant.