-
Notifications
You must be signed in to change notification settings - Fork 59
chore: fix .gitignore to not ignore schema.go #3150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Does the PR have any schema changes?Found 239 breaking changes: Resources
Functions
Types
Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3150 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 3 3
Lines 164 164
======================================
Misses 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why this was added to the gitignore?
Not sure. Also schema checks are going haywire? |
master just failed. Disappointing. |
There are files under sdk that match schema.go they probably should not be ignored.