Add Mise to pulumi-java
#1717
Open
Add Mise to pulumi-java
#1717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunaris
added
the
impact/no-changelog-required
tgummerer
approved these changes
Mar 3, 2025
Comment on lines
+11
to
+16
| node = "20" | ||
| "npm:pnpm" = "latest" | ||
| "npm:typescript" = "latest" | ||
| "npm:typescript-language-server" = "latest" | ||
| "npm:yarn" = "latest" | ||
| python = "3.11" |
There was a problem hiding this comment.
Is this required to build Java?
There was a problem hiding this comment.
I've been a bit cautious since the pulumi submodule means that in theory you may be dipping in and out of the "full monorepo" at points and it's (IMO) handy to have a superset of that tooling available. But I'm happy if we think this is a bad call.
There was a problem hiding this comment.
Shoudl we add dotnet too in that case? I'm fine either way to be clear, happy to get this in eithre way.
|
I got the following error on this branch: Do I need to do some extra setup? |
This change adds a `.mise.toml` to the repository so that [Mise](https://mise.jdx.dev) can be used to manage developer tooling for `pulumi-java`. This is inline with other PRs across our estate, such as pulumi/pulumi#18626. Developers with Mise installed can now run `mise trust` in `pulumi-java` and have the relevant tooling installed for running `make`, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
.mise.tomlto the repository so that Mise can be used to manage developer tooling forpulumi-java. This is inline with other PRs across our estate, such as pulumi/pulumi#18626. Developers with Mise installed can now runmise trustinpulumi-javaand have the relevant tooling installed for runningmake, etc.