Skip to content

feat: reduce docker image size by 30% #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

project0
Copy link
Contributor

Proposed changes

apply common best practice for production builds to reduce weight of produced binaries. This decrease the size significantly from 171MB to 119MB.

Related issues (optional)

Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@EronWright
Copy link
Contributor

Interesting, and thanks for the contribution. We'll merge this shortly.

Some information: golang/go#26074

@EronWright EronWright self-assigned this Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.17%. Comparing base (a42f498) to head (d3f7e19).
Report is 50 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #852   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files          33       33           
  Lines        4556     4556           
=======================================
  Hits         2377     2377           
  Misses       1986     1986           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

project0 and others added 3 commits May 19, 2025 15:21
apply common best practice for production builds to reduce weight of
produced binaries. This decrease the size significantly from 171MB to 119MB.
Remove the `-s` flag
@EronWright EronWright force-pushed the feat/optimize-image-size branch from d3f7e19 to 60a62f0 Compare May 19, 2025 22:31
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@EronWright
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

@EronWright
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

@EronWright
Copy link
Contributor

Closing this PR to re-open as a non-fork PR.
#917

@EronWright EronWright closed this May 20, 2025
EronWright added a commit that referenced this pull request May 20, 2025
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
    for Pulumi's contribution guidelines.

    Help us merge your changes more quickly by adding more details such
    as labels, milestones, and reviewers.-->

### Proposed changes

<!--Give us a brief description of what you've done and what it solves.
-->

Based on: #852

apply common best practice for production builds to reduce weight of
produced binaries. This decrease the size significantly from 171MB to
119MB

### Related issues (optional)

<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->

---------

Co-authored-by: Richard Hillmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants