-
Notifications
You must be signed in to change notification settings - Fork 64
feat: reduce docker image size by 30% #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
Interesting, and thanks for the contribution. We'll merge this shortly. Some information: golang/go#26074 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 52.17% 52.17%
=======================================
Files 33 33
Lines 4556 4556
=======================================
Hits 2377 2377
Misses 1986 1986
Partials 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
apply common best practice for production builds to reduce weight of produced binaries. This decrease the size significantly from 171MB to 119MB.
Remove the `-s` flag
d3f7e19
to
60a62f0
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-kubernetes-operator/actions/runs/15124529137 |
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-kubernetes-operator/actions/runs/15125461224 |
Closing this PR to re-open as a non-fork PR. |
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes <!--Give us a brief description of what you've done and what it solves. --> Based on: #852 apply common best practice for production builds to reduce weight of produced binaries. This decrease the size significantly from 171MB to 119MB ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. --> --------- Co-authored-by: Richard Hillmann <[email protected]>
Proposed changes
apply common best practice for production builds to reduce weight of produced binaries. This decrease the size significantly from 171MB to 119MB.
Related issues (optional)