Skip to content

fix: indentation in cluster role with extra rules #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

fix: indentation in cluster role with extra rules #875

merged 1 commit into from
May 19, 2025

Conversation

rassie
Copy link
Contributor

@rassie rassie commented Mar 21, 2025

Proposed changes

When setting rbac.extraRules in the Helm chart, rendered template has the wrong indentation. This fixes the indentation.

@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@EronWright EronWright self-requested a review April 7, 2025 18:46
@EronWright EronWright self-assigned this Apr 7, 2025
EronWright
EronWright approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EronWright EronWright enabled auto-merge (squash) May 19, 2025 19:58
@EronWright
Copy link
Contributor

/run-acceptance-tests

@EronWright EronWright marked this pull request as draft May 19, 2025 21:46
auto-merge was automatically disabled May 19, 2025 21:46

Pull request was converted to draft

@EronWright EronWright marked this pull request as ready for review May 19, 2025 21:46
@EronWright
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-kubernetes-operator/actions/runs/15123928487

@EronWright EronWright merged commit d97be71 into pulumi:master May 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EronWright EronWright EronWright approved these changes

Assignees

@EronWright EronWright

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rassie @EronWright @pulumi-bot