Skip to content

Use ESC secrets #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use ESC secrets #895

wants to merge 1 commit into from

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Apr 29, 2025

These changes migrate this repo's GitHub Actions Workflows to use ESC secrets instead of GitHub Secrets.

The changes are largely mechanical:

  • Common configuration for all ESC actions within a workflow is added to the workflow's environment variables
  • Permissions are expanded as necessary for workflows that do not grant id-token: write permissions
    • read-all permissions are replaced with the union of all explicit read permissions and id-token: write
    • Default permissions are replaced with write-all, which is the equivalent of all explicit write permissions and
      id-token: write
    • Explicit permissions are modified to grant id-token: write
  • A step that fetches ESC secrets and populates environment variables is added to each step that reads secrets
  • Direct references to secrets within the job are replaced with references to the step's outputs

All ESC actions are configured to fetch secrets from a shared ESC environment that contains secrets migrated from GitHub Actions. The ESC action performs its own OIDC exchange to obtain a Pulumi Access Token.

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.17%. Comparing base (f01d73c) to head (5ad27f2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files          33       33           
  Lines        4556     4556           
=======================================
  Hits         2377     2377           
  Misses       1986     1986           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pgavlin pgavlin force-pushed the pgavlin/esc-secrets branch from 69b42a6 to a6e6b4a Compare April 30, 2025 18:35
@pgavlin pgavlin requested a review from komalali April 30, 2025 18:35
@pgavlin pgavlin added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 30, 2025
@pgavlin pgavlin force-pushed the pgavlin/esc-secrets branch from a6e6b4a to 615fe38 Compare April 30, 2025 18:51
@pgavlin pgavlin force-pushed the pgavlin/esc-secrets branch from 615fe38 to 5ad27f2 Compare April 30, 2025 19:41
@EronWright EronWright self-assigned this May 19, 2025
@EronWright
Copy link
Contributor

Thanks for the contribution, I'll take it from here and ship it in M121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants