Skip to content

Add review guidelines for sdk.instructions.md #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rshade wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add review guidelines for sdk.instructions.md #604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e92b636
Add review guidelines for sdk.instructions.md
rshade Nov 13, 2025
3d7e255
Update .github/sdk.instructions.md
rshade Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/sdk.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
If schema.json has changed, verify that the SDK files in this folder have been regenerated by running `make build_sdks`.
Otherwise, the files in this folder are auto-generated and should not be reviewed.
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "the files in this folder" is ambiguous since this instruction file is in .github/ but refers to files in the sdk/ folder. Consider making this more explicit: "Otherwise, the files in the sdk/ folder are auto-generated and should not be reviewed."

Suggested change
Otherwise, the files in this folder are auto-generated and should not be reviewed.
Otherwise, the files in the `sdk/` folder are auto-generated and should not be reviewed.

Copilot uses AI. Check for mistakes.
Loading