-
Notifications
You must be signed in to change notification settings - Fork 47
PF detailed diff #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF detailed diff #2629
Changes from all commits
c16de25
3e575cf
42f65a2
683f670
7874e83
3946fe8
2cd4e71
1269140
c769323
ec10aa3
528af95
da9cd71
6e8adbe
973ba94
69348fc
897bf79
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,22 @@ | ||
{ | ||
"changes": "DIFF_SOME", | ||
"detailedDiff": { | ||
"attrNumberComputed": {}, | ||
"attrNumberRequired": { | ||
"kind": "DELETE" | ||
}, | ||
"attrStringDefault": {}, | ||
"attrStringDefaultOverridden": {}, | ||
"attrStringRequired": { | ||
"kind": "UPDATE" | ||
} | ||
}, | ||
"diffs": [ | ||
"attrNumberComputed", | ||
"attrNumberRequired", | ||
"attrStringDefault", | ||
"attrStringDefaultOverridden", | ||
"attrStringRequired" | ||
] | ||
], | ||
"hasDetailedDiff": true | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ import ( | |
) | ||
|
||
func TestSecretBasic(t *testing.T) { | ||
t.Skip("skipping until #2643") | ||
t.Parallel() | ||
provBuilder := providerbuilder.NewProvider( | ||
providerbuilder.NewProviderArgs{ | ||
|
@@ -65,6 +66,7 @@ Resources: | |
} | ||
|
||
func TestSecretSet(t *testing.T) { | ||
t.Skip("skipping until #2643") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in #2643 |
||
t.Parallel() | ||
|
||
provBuilder := pb.NewProvider(pb.NewProviderArgs{ | ||
|
@@ -158,6 +160,7 @@ Resources: | |
} | ||
|
||
func TestSecretObjectBlock(t *testing.T) { | ||
t.Skip("skipping until #2643") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in #2643 |
||
t.Parallel() | ||
|
||
provBuilder := pb.NewProvider(pb.NewProviderArgs{ | ||
|
@@ -259,6 +262,7 @@ Resources: | |
} | ||
|
||
func TestSecretPulumiSchema(t *testing.T) { | ||
t.Skip("skipping until #2643") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in #2643 |
||
t.Parallel() | ||
|
||
provBuilder := pb.NewProvider(pb.NewProviderArgs{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,7 +80,13 @@ func TestOptionRemovalTestresDiff(t *testing.T) { | |
"changes": "DIFF_SOME", | ||
"diffs": [ | ||
"optionalInputString" | ||
] | ||
], | ||
"hasDetailedDiff": true, | ||
"detailedDiff": { | ||
"optionalInputString": { | ||
"kind": "DELETE" | ||
} | ||
} | ||
} | ||
} | ||
` | ||
|
@@ -121,6 +127,8 @@ func TestEmptyTestresDiffWithOptionalComputed(t *testing.T) { | |
|
||
func TestDiffWithSecrets(t *testing.T) { | ||
t.Parallel() | ||
t.Skip("TODO: secrets") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in #2643 |
||
|
||
server, err := newProviderServer(t, testprovider.RandomProvider()) | ||
require.NoError(t, err) | ||
|
||
|
@@ -165,6 +173,7 @@ func TestDiffWithSecrets(t *testing.T) { | |
// See https://github.com/pulumi/pulumi-random/issues/258 | ||
func TestDiffVersionUpgrade(t *testing.T) { | ||
t.Parallel() | ||
t.Skip("TODO: secrets") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in #2643 |
||
server, err := newProviderServer(t, testprovider.RandomProvider()) | ||
require.NoError(t, err) | ||
testCase := ` | ||
|
@@ -307,7 +316,13 @@ func TestSetNestedObjectAddedOtherDiff(t *testing.T) { | |
"diffs": [ | ||
"other", | ||
"vlanNames" | ||
] | ||
], | ||
"hasDetailedDiff": true, | ||
"detailedDiff": { | ||
"other": { | ||
"kind": "UPDATE" | ||
} | ||
} | ||
} | ||
} | ||
` | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,6 @@ Plan: 0 to add, 1 to change, 0 to destroy. | |
[id=test-id] | ||
[urn=urn:pulumi:test::project::testprovider:index/test:Test::p] | ||
~ keys: [ | ||
[0]: "val1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks bad still? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, this is #2295 |
||
~ [1]: "val3" => "val2" | ||
+ [2]: "val3" | ||
] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,6 @@ Plan: 1 to add, 0 to change, 1 to destroy. | |
+-testprovider:index/test:Test: (replace) | ||
[id=test-id] | ||
[urn=urn:pulumi:test::project::testprovider:index/test:Test::p] | ||
~ id : "test-id" => output<string> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is wrong, will fix in #2660 Similar for all other cases when an ID diff is not displayed for a replace. |
||
~ keys: [ | ||
+ [0]: "value" | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #2643