-
Notifications
You must be signed in to change notification settings - Fork 50
Detailed diff handle secrets and outputs #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 20, 2024
Merged
00f3e0a to
a802849
Compare
c03b097 to
52e8be2
Compare
52bf5ef to
65bc464
Compare
11c6396 to
c144b41
Compare
65bc464 to
6427e13
Compare
60e32d2 to
5a9f4e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2643 +/- ##
==========================================
+ Coverage 69.43% 69.45% +0.01%
==========================================
Files 301 301
Lines 38613 38626 +13
==========================================
+ Hits 26811 26827 +16
+ Misses 10277 10275 -2
+ Partials 1525 1524 -1 ☔ View full report in Codecov by Sentry. |
6427e13 to
c17797f
Compare
5a9f4e0 to
0c77fff
Compare
7ea31ea to
112d26b
Compare
0c77fff to
fb364c0
Compare
112d26b to
40ca17e
Compare
fb364c0 to
8965216
Compare
40ca17e to
2881d5d
Compare
8965216 to
ede0755
Compare
This was referenced Nov 22, 2024
2881d5d to
4a03e18
Compare
ede0755 to
3d3d520
Compare
3d3d520 to
1ef66c3
Compare
318058f to
f354cdb
Compare
cf4362c to
f86a647
Compare
f354cdb to
8a0f428
Compare
f86a647 to
0268a08
Compare
8a0f428 to
3291da2
Compare
0268a08 to
4bea1d9
Compare
7258b95 to
ca0b7a2
Compare
4bea1d9 to
2029b99
Compare
ca0b7a2 to
f7072ac
Compare
Base automatically changed from
vvm/pf_accurate_previews_feature_flag
to
master
November 25, 2024 17:43
f7072ac to
a6a1abf
Compare
a6a1abf to
ea8fb88
Compare
ea8fb88 to
e1a6d27
Compare
e1a6d27 to
64d59f8
Compare
Contributor
|
This PR has been shipped in release v3.97.0. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds secret and output handling to the detailed diff v2 code. Secrets and outputs are not necessary for the algorithm so we just strip both from the inputs.
fixes #2526
fixes #2651