Skip to content

Add detailed diff recordings to PF diff tests #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Add detailed diff recordings to PF diff tests #2657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d980cf0
Add detailed diff recordings to PF diff tests
VenelinMartinov Nov 22, 2024
e562437
test recordings
VenelinMartinov Nov 22, 2024
630cd8b
lint
VenelinMartinov Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions pkg/pf/tests/diff_list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ func TestDetailedDiffList(t *testing.T) {
changeValue *[]string
tfOut string
pulumiOut string
detailedDiff map[string]any
}

for _, schemaValueMakerPair := range schemaValueMakerPairs {
Expand All @@ -242,6 +243,7 @@ func TestDetailedDiffList(t *testing.T) {
changeValue: scenario.changeValue,
tfOut: diff.TFOut,
pulumiOut: diff.PulumiOut,
detailedDiff: diff.PulumiDiff.DetailedDiff,
})
})
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/pf/tests/diff_map_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ func TestDetailedDiffMap(t *testing.T) {
changeValue *map[string]*string
tfOut string
pulumiOut string
detailedDiff map[string]any
}

for _, schemaValueMakerPair := range schemaValueMakerPairs {
Expand All @@ -184,6 +185,7 @@ func TestDetailedDiffMap(t *testing.T) {
changeValue: scenario.changeValue,
tfOut: diff.TFOut,
pulumiOut: diff.PulumiOut,
detailedDiff: diff.PulumiDiff.DetailedDiff,
})
})
}
Expand Down
3 changes: 3 additions & 0 deletions pkg/pf/tests/diff_object_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ func TestDetailedDiffObject(t *testing.T) {
changeValue *map[string]string
tfOut string
pulumiOut string
detailedDiff map[string]any
}

for _, schema := range schemas {
Expand All @@ -342,6 +343,7 @@ func TestDetailedDiffObject(t *testing.T) {
changeValue: scenario.changeValue,
tfOut: diff.TFOut,
pulumiOut: diff.PulumiOut,
detailedDiff: diff.PulumiDiff.DetailedDiff,
})
})
}
Expand All @@ -361,6 +363,7 @@ func TestDetailedDiffObject(t *testing.T) {
changeValue: scenario.changeValue,
tfOut: diff.TFOut,
pulumiOut: diff.PulumiOut,
detailedDiff: diff.PulumiDiff.DetailedDiff,
})
})
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/pf/tests/diff_set_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,7 @@ func TestDetailedDiffSet(t *testing.T) {
changeValue *[]string
tfOut string
pulumiOut string
detailedDiff map[string]any
}

for _, schemaValueMakerPair := range schemaValueMakerPairs {
Expand All @@ -601,6 +602,7 @@ func TestDetailedDiffSet(t *testing.T) {
changeValue: scenario.changeValue,
tfOut: diff.TFOut,
pulumiOut: diff.PulumiOut,
detailedDiff: diff.PulumiDiff.DetailedDiff,
})
})
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/pf/tests/diff_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ func TestDetailedDiffStringAttribute(t *testing.T) {
changeValue *string
tfOut string
pulumiOut string
detailedDiff map[string]any
}

for _, schema := range schemas {
Expand All @@ -201,6 +202,7 @@ func TestDetailedDiffStringAttribute(t *testing.T) {
changeValue: scenario.changeValue,
tfOut: diff.TFOut,
pulumiOut: diff.PulumiOut,
detailedDiff: diff.PulumiDiff.DetailedDiff,
})
})
}
Expand Down
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/added.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[0]": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/added_end.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[2]": map[string]interface{}{}},
}
5 changes: 5 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/added_front.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,9 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[0]": map[string]interface{}{"kind": "UPDATE"},
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{},
},
}
4 changes: 4 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/added_middle.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,8 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{},
},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/changed_empty_to_null.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/changed_non-empty.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[0]": map[string]interface{}{"kind": "UPDATE"}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/changed_null_to_empty.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/element_added.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[1]": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/element_removed.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[1]": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/long_list_added.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[20]": map[string]interface{}{}},
}
23 changes: 23 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/long_list_added_front.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,27 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[0]": map[string]interface{}{"kind": "UPDATE"},
"keys[10]": map[string]interface{}{"kind": "UPDATE"},
"keys[11]": map[string]interface{}{"kind": "UPDATE"},
"keys[12]": map[string]interface{}{"kind": "UPDATE"},
"keys[13]": map[string]interface{}{"kind": "UPDATE"},
"keys[14]": map[string]interface{}{"kind": "UPDATE"},
"keys[15]": map[string]interface{}{"kind": "UPDATE"},
"keys[16]": map[string]interface{}{"kind": "UPDATE"},
"keys[17]": map[string]interface{}{"kind": "UPDATE"},
"keys[18]": map[string]interface{}{"kind": "UPDATE"},
"keys[19]": map[string]interface{}{"kind": "UPDATE"},
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[20]": map[string]interface{}{},
"keys[2]": map[string]interface{}{"kind": "UPDATE"},
"keys[3]": map[string]interface{}{"kind": "UPDATE"},
"keys[4]": map[string]interface{}{"kind": "UPDATE"},
"keys[5]": map[string]interface{}{"kind": "UPDATE"},
"keys[6]": map[string]interface{}{"kind": "UPDATE"},
"keys[7]": map[string]interface{}{"kind": "UPDATE"},
"keys[8]": map[string]interface{}{"kind": "UPDATE"},
"keys[9]": map[string]interface{}{"kind": "UPDATE"},
},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/non-null_to_null.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/null_to_non-null.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/removed.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[0]": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/removed_end.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[2]": map[string]interface{}{"kind": "DELETE"}},
}
5 changes: 5 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/removed_front.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,9 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[0]": map[string]interface{}{"kind": "UPDATE"},
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{"kind": "DELETE"},
},
}
4 changes: 4 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_no_replace/removed_middle.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,8 @@ Resources:
~ 1 to update
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{"kind": "DELETE"},
},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/added.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[0]": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/added_end.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[2]": map[string]interface{}{}},
}
5 changes: 5 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/added_front.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,9 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[0]": map[string]interface{}{"kind": "UPDATE"},
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{},
},
}
4 changes: 4 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/added_middle.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,8 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{},
},
}
1 change: 1 addition & 0 deletions ...sts/testdata/TestDetailedDiffList/attribute_requires_replace/changed_empty_to_null.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions ...f/tests/testdata/TestDetailedDiffList/attribute_requires_replace/changed_non-empty.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[0]": map[string]interface{}{"kind": "UPDATE"}},
}
1 change: 1 addition & 0 deletions ...sts/testdata/TestDetailedDiffList/attribute_requires_replace/changed_null_to_empty.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/element_added.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[1]": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/element_removed.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[1]": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/long_list_added.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[20]": map[string]interface{}{}},
}
23 changes: 23 additions & 0 deletions ...sts/testdata/TestDetailedDiffList/attribute_requires_replace/long_list_added_front.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,27 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[0]": map[string]interface{}{"kind": "UPDATE"},
"keys[10]": map[string]interface{}{"kind": "UPDATE"},
"keys[11]": map[string]interface{}{"kind": "UPDATE"},
"keys[12]": map[string]interface{}{"kind": "UPDATE"},
"keys[13]": map[string]interface{}{"kind": "UPDATE"},
"keys[14]": map[string]interface{}{"kind": "UPDATE"},
"keys[15]": map[string]interface{}{"kind": "UPDATE"},
"keys[16]": map[string]interface{}{"kind": "UPDATE"},
"keys[17]": map[string]interface{}{"kind": "UPDATE"},
"keys[18]": map[string]interface{}{"kind": "UPDATE"},
"keys[19]": map[string]interface{}{"kind": "UPDATE"},
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[20]": map[string]interface{}{},
"keys[2]": map[string]interface{}{"kind": "UPDATE"},
"keys[3]": map[string]interface{}{"kind": "UPDATE"},
"keys[4]": map[string]interface{}{"kind": "UPDATE"},
"keys[5]": map[string]interface{}{"kind": "UPDATE"},
"keys[6]": map[string]interface{}{"kind": "UPDATE"},
"keys[7]": map[string]interface{}{"kind": "UPDATE"},
"keys[8]": map[string]interface{}{"kind": "UPDATE"},
"keys[9]": map[string]interface{}{"kind": "UPDATE"},
},
}
1 change: 1 addition & 0 deletions ...pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/non-null_to_null.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions ...pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/null_to_non-null.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/removed.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[0]": map[string]interface{}{"kind": "DELETE"}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/removed_end.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[2]": map[string]interface{}{"kind": "DELETE"}},
}
5 changes: 5 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/removed_front.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,9 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[0]": map[string]interface{}{"kind": "UPDATE"},
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{"kind": "DELETE"},
},
}
4 changes: 4 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/attribute_requires_replace/removed_middle.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,8 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[1]": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{"kind": "DELETE"},
},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/block_nested_requires_replace/added.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[0]": map[string]interface{}{}},
}
1 change: 1 addition & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/block_nested_requires_replace/added_end.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{"keys[2]": map[string]interface{}{}},
}
5 changes: 5 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/block_nested_requires_replace/added_front.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,9 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[0].nested": map[string]interface{}{"kind": "UPDATE"},
"keys[1].nested": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{},
},
}
4 changes: 4 additions & 0 deletions pkg/pf/tests/testdata/TestDetailedDiffList/block_nested_requires_replace/added_middle.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,8 @@ Resources:
+-1 to replace
1 unchanged
`,
detailedDiff: map[string]interface{}{
"keys[1].nested": map[string]interface{}{"kind": "UPDATE"},
"keys[2]": map[string]interface{}{},
},
}
Loading
Loading