Skip to content

Generate SDKs via pulumi package gen-sdk #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 27, 2025
Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented May 7, 2025

This PR removes the direct function calls into programgen for SDK generation in the bridge. Instead we now rely on the pulumi cli for this via pkg gen-sdk. This should produce no changes in the generated SDKs.

I've verified that AWS builds fine and has no SDK changes under this change. CI run here: pulumi/pulumi-aws#5512

fixes #1488

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 51.13636% with 43 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (640b799) to head (95a6b47).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/tfgen/generate.go 51.13% 29 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
+ Coverage   68.62%   68.80%   +0.18%     
==========================================
  Files         335      335              
  Lines       43479    43561      +82     
==========================================
+ Hits        29837    29972     +135     
+ Misses      11959    11877      -82     
- Partials     1683     1712      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VenelinMartinov VenelinMartinov changed the title wip [WIP] Generate SDKs via pulumi package gen-sdk May 8, 2025
@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch 3 times, most recently from 5fd1dc2 to 6d1ab38 Compare May 9, 2025 13:24
@VenelinMartinov VenelinMartinov changed the base branch from main to vvm/bump_pu_pu_3.169.0 May 9, 2025 15:59
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented May 9, 2025

This change is part of the following stack:

Change managed by git-spice.

@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch from bc5993a to 0987bae Compare May 9, 2025 15:59
@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch 4 times, most recently from 62e78e4 to 780c721 Compare May 9, 2025 16:52
@VenelinMartinov VenelinMartinov requested review from t0yv0 and a team May 9, 2025 17:10
@VenelinMartinov VenelinMartinov marked this pull request as ready for review May 9, 2025 17:10
@VenelinMartinov VenelinMartinov changed the title [WIP] Generate SDKs via pulumi package gen-sdk Generate SDKs via pulumi package gen-sdk May 9, 2025
Base automatically changed from vvm/bump_pu_pu_3.169.0 to main May 12, 2025 14:48
@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch 2 times, most recently from 156acb0 to 0f1a47e Compare May 12, 2025 15:18
@VenelinMartinov
Copy link
Contributor Author

Found an issue with Csharp gen-sdk during testing: pulumi/pulumi#19554

@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch from 0f1a47e to 01162f2 Compare May 27, 2025 10:23
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) May 27, 2025 13:09
@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch from c6b6dc3 to 95a6b47 Compare May 27, 2025 13:19
@VenelinMartinov VenelinMartinov merged commit bde4b60 into main May 27, 2025
136 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/gen_sdk_generation branch May 27, 2025 13:39
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.109.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke SDK generation via pulumi package gen-sdk --language ${LANG}
3 participants