Test some ignoreChanges functionality #3175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some tests for the `ignoreChanges` functionality, specifically for sdkv2. Some things this highlights: - wildcards (for lists, sets, maps) do not get processed at all in the bridge. We completely rely on `ignoreChanges` in core. - Do we need `ignoreChanges` processing in the bridge at all? Is the logic in core enough?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3175 +/- ##
==========================================
- Coverage 68.80% 68.79% -0.01%
==========================================
Files 336 336
Lines 43848 43868 +20
==========================================
+ Hits 30171 30181 +10
- Misses 11979 11988 +9
- Partials 1698 1699 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some tests for the
ignoreChangesfunctionality, specifically for sdkv2. Some things this highlights:ignoreChangesin core.ignoreChangesprocessing in the bridge at all? Is the logic in core enough?It looks like
ignoreChangesis processed here, but the way it is currently written wildcards will never be matched.re #3186
re #3177
Caution
Currently blocked by upgrading pu/pu to 3.194.0 which includes some fixes to ignoreChanges.