Add support for List Resource from TF - #3232
Draft
Zaid-Ajaj wants to merge 6 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3232 +/- ##
==========================================
- Coverage 68.62% 68.55% -0.08%
==========================================
Files 338 322 -16
Lines 44181 35956 -8225
==========================================
- Hits 30318 24648 -5670
+ Misses 12128 9536 -2592
- Partials 1735 1772 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraform added List Resources support back in terraform v1.14 and this PR implements it in the bridge.
List resources are a new special resource type which are not really resources, they act more like
data_sourceswhere they an input of the shape:and the output are of the shape
Where
<INPUT_CONFIG>and<OUTPUT_TYPE>are defined in the schema of the ListResource in question.In this PR, we implement these list resources as invokes since they are stateless and can be treated as functions of the provider. This way, we get SDK-gen support out of the box without any changes to the CLI or engine.
TODO: