raw state: null check strings and numbers - #3286
Open
pgavlin wants to merge 1 commit into
Open
Conversation
cty string and number values need to be null-checked prior to calling `AsString` or `AsBigFloat`, respectively. If the cty values are null, these functions will panic. Fixes #3278.
pgavlin
marked this pull request as ready for review
December 22, 2025 18:53
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3286 +/- ##
=======================================
Coverage 69.75% 69.76%
=======================================
Files 338 338
Lines 36456 36456
=======================================
+ Hits 25430 25432 +2
+ Misses 9296 9295 -1
+ Partials 1730 1729 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@pgavlin it looks like this PR removes the panic, but now we get the error |
corymhall
removed their request for review
February 17, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cty string and number values need to be null-checked prior to calling
AsStringorAsBigFloat, respectively. If the cty values are null,these functions will panic.
Fixes #3278.