Skip to content

chore: remove google-native package from registry#10980

Open
pierskarsenbarg wants to merge 1 commit into
masterfrom
remove-google-native
Open

chore: remove google-native package from registry#10980
pierskarsenbarg wants to merge 1 commit into
masterfrom
remove-google-native

Conversation

@pierskarsenbarg
Copy link
Copy Markdown
Member

Summary

  • Removes the google-native provider package from the Pulumi Registry
  • Deletes the package YAML file and associated content pages (_index.md, installation-configuration.md)
  • Removes the google-native schema fixture and cleans up references in resourcedocsgen (gen.go, lookup.go, and related tests)

Test plan

  • Verify make lint passes
  • Confirm no references to google-native remain in themes/default/data/registry/packages/ or resourcedocsgen

google-native is no longer under active development. Removes the
registry package YAML, content pages, lookup entries, and test
fixtures (replacing external google-native schema refs with
azure-native equivalents and regenerating golden files).
@claude
Copy link
Copy Markdown

claude Bot commented May 12, 2026

Registry Review — PR #10980 (chore: remove google-native package from registry)

Thanks for the cleanup! The removal of the YAML, content pages, schema fixture, and the entries in gen.go / lookup.go / gen_package_test.go all look correct. However, several google-native references remain in the tree and resourcedocsgen / Test is currently failing — likely because of one of them. The PR is also labeled do-not-merge, so I assume you're aware it's not ready yet, but here is what I found that still needs attention.


1. Test fixtures still reference google-native in HCL sections (probably the test failure)

The diff updates the C#, Go, Java, Python, TypeScript, and YAML language sections in the two fixture files, but the HCL sections were not regenerated and still point to the now-deleted google-native schema.

tools/resourcedocsgen/pkg/docs/testdata/TestGeneratePackage/enum-reference/docs/myModule/iamresource/_index.md — line 416:

    <dd>This type is defined in the <a href="/registry/packages/azure-native">Azure Native</a> package.</dd></dl>

(And the surrounding HCL block around line 414 — <a href=\"#auditconfig\">object</a> — also still mentions auditconfig rather than notificationsettings, so the whole HCL <dl> for this fixture likely needs to be regenerated, not just the line above.)

tools/resourcedocsgen/pkg/docs/testdata/TestGeneratePackage/external-enum/docs/component/_index.md — line 273 (HCL example), line 413 (property type), line 415 (definition link):

    <dd>This type is defined in the <a href="/registry/packages/azure-native">Azure Native</a> package.</dd></dl>

Line 273 still has remote_enum = \"MANAGEMENT_UNSPECIFIED\" and line 413 still lists \"MANAGEMENT_UNSPECIFIED\" | \"NONE\" | \"BASIC\" | \"COMPLETE\" along with #devicepolicyalloweddevicemanagementlevelsitem — all references to the removed DevicePolicyAllowedDeviceManagementLevelsItem enum from google-native. These should be the corresponding ExternalAccess values (\"Enabled\" | \"Disabled\") from azure-native to be consistent with the rest of the file.

Regenerating these fixtures (e.g. go test ./pkg/docs -update or whatever the project's fixture-refresh flag is) should fix the failing resourcedocsgen / Test check.


2. themes/default/layouts/partials/registry/package/package-alert.html — dead branch

Lines 28–40 still contain a special-case alert block for google-native that points to /registry/packages/gcp/. With the package gone, this branch is unreachable and should be removed:

{{ else if (eq $package "confluent") }}

(Applied as a replacement for the {{ else if (eq $package \"google-native\") }} … {{ else if (eq $package \"confluent\") }} block at lines 28–41.)


3. scripts/run-browser-tests.js — line 24

\"google-native\" is still in the singles array used to split large packages out of the bulk browser-test runs. Since the package is being removed, the entry should be dropped:

    "gcp",
    "kubernetes",

(Applied as a replacement for lines 23–25 — i.e. \"gcp\", \"google-native\", \"kubernetes\", becomes \"gcp\", \"kubernetes\",.)


4. scripts/search/rank.js — lines 35, 126, 131

The search-ranking rules still include google-native in three regex alternations. With no /registry/packages/google-native/ pages, these patterns can never match and should be tidied up:

  • Line 35:
            /^\/registry\/packages\/(aws|aws-native|azure|azure-native|gcp|kubernetes)\/$/,
  • Line 126:
                /^\/registry\/packages\/(aws-native|azure|digitalocean)\//,
  • Line 131:
                    /^\/registry\/packages\/(aws-native|azure|digitalocean)\/$/,

Note the line-39 logic (return [match[1].replace(\"-native\", \"\")];) still works correctly once google-native is removed.


Smaller / informational

  • The PR description's test plan still has unchecked boxes — once the above is addressed and make lint / make test pass, that should be filled in.
  • The do-not-merge label is currently applied, so this is presumably still WIP — flagging the above so it can be wrapped up before the label is removed.
  • The Google Cloud Native page in production will start 404-ing once this lands. Worth confirming with whoever owns redirects whether /registry/packages/google-native/ should redirect somewhere (e.g. to /registry/packages/gcp/) rather than just disappear.

Once the HCL fixture regeneration in (1) is done, resourcedocsgen / Test should pass and the cleanup will be complete. Mention me (@claude) if you'd like another pass after pushing fixes.

@github-actions
Copy link
Copy Markdown
Contributor

Your site preview for commit 4b38dab is ready! 🎉

http://registry--origin-pr-10980-4b38dab6.s3-website.us-west-2.amazonaws.com/registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant