Add atensecurity/pulumi-thoth to community package list#11056
Open
atensecurity-bot wants to merge 1 commit into
Open
Add atensecurity/pulumi-thoth to community package list#11056atensecurity-bot wants to merge 1 commit into
atensecurity-bot wants to merge 1 commit into
Conversation
|
@fnune PR updated here |
fnune
requested changes
May 19, 2026
fnune
left a comment
Member
There was a problem hiding this comment.
Before this can merge, the following need to land in the upstream atensecurity/pulumi-thoth repo and a new tagged release:
Required
- Add
docs/_index.mdanddocs/installation-configuration.md. Both 404 at v0.1.11 andmain; thedocs/directory does not exist. Required by the checklist; they render the registry overview and install pages. - Reconcile declared vs. published languages. The schema's
languageblock declares["csharp", "go", "nodejs", "python"], but only Python and .NET are published. Either publish npm + prime pkg.go.dev for Go, or dropnodejs/gofrom the schema so the registry doesn't advertise install steps that don't work. - Bring the PyPI release in line with the provider version.
pulumi-thothis at0.1.0; provider is atv0.1.11. Python publish step appears to have stopped after the initial release; check.goreleaser.yml.
FYI
- Issue #10871 categorises this as "Native", but the entrypoint imports
pulumi-terraform-bridge/v3/pkg/pf/tfbridge. It's a Terraform Plugin Framework bridge. No effect on publishing.
Re-tag, then this PR can be re-reviewed in place.
fnune
added a commit
that referenced
this pull request
May 19, 2026
Three changes after a real run against #11056 surfaced friction: 1. Comment-style brevity rules for all generated PR comments, review bodies, and close messages: under 150 words, no em-dashes, no opening preamble or closing flourish, one-line asks with the why in a parenthetical or link. The previous default produced ~400-word walls of text with em-dashes throughout, against the global style the maintainer has set. 2. SDK presence probe is now driven by the schema's language map, not an assumption that all four (TS/Python/Go/C#) are required. A declared language with no published SDK is Fail; a published SDK that lags the provider version by more than one minor is also Fail (the schema promises an API the SDK does not expose); undeclared languages are not probed. 3. Obvious packaging-config bugs in published SDK names (doubled tokens like Foo.Pulumi.Bar.Bar from a misconfigured tfgen rootNamespace) are now an explicit Warn pattern, not just "best effort, varies." ## Test plan - Re-ran the comment redraft from the #11056 review with the new brevity rules: 120 words vs the previous 400, no em-dashes, identical action items. - Confirmed against atensecurity/pulumi-thoth that its schema declares all four languages, so the SDK probe still flags the missing npm publish and the lagging PyPI publish; behaviour on that PR is unchanged but the skill no longer over-asks for providers that intentionally ship fewer SDKs.
1f77f8c to
b00201c
Compare
Author
|
@fnune, Refreshing this PR with the latest branch update and Update made on June 23, 2026:
Could we get this re-reviewed in place? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
atensecurity/pulumi-thothto the Pulumi community package list.provider/cmd/pulumi-resource-thoth/schema.jsonRequested as part of initial community registry publication for the Thoth Pulumi provider.